1278008 - Cannot use Adjust OnAttributionChangedListener: java.lang.NoClassDefFoundError: com/adjust/sdk/OnAttributionChangedListener

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Full trace

Important bit of trace:

org.mozilla.gecko.annotationProcessors.utils.GeneratableElementIterator.getFilteredInnerClasses(GeneratableElementIterator.java:70)
     1:12.58        at org.mozilla.gecko.annotationProcessors.utils.GeneratableElementIterator.getInnerClasses(GeneratableElementIterator.java:88)
     1:12.58        at org.mozilla.gecko.annotationProcessors.AnnotationProcessor.generateClass(AnnotationProcessor.java:112)
     1:12.58        at org.mozilla.gecko.annotationProcessors.AnnotationProcessor.main(AnnotationProcessor.java:83)

It looks like our annotation processors, which I assume work on the method/class signature level, do not have access to the Adjust build dependencies and are throwing there.

Quick fix: just catch the exception & move on with our lives.

I don't know what I proper fix would look like.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1278008 - Add all_jars to annotation processing classpath.

Because I don't know much about the build system, this may not be an optimal
fix. See the added code comments for more details.

Since this is an annotation processor and they tend to be self-analyzing, my
one concern is that this code uses the classpath in some way to identify which
files need to be kept. That being said:
 1) I don't think it makes sense to use the classpath in this way, particularly
when the files we want to operate on are passed as a command line argument.
 2) My build did not warn me that the generated JNI wrappers have changed so I
expect no side effects from this change.

Review commit: https://reviewboard.mozilla.org/r/57958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57958/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8760363 [details]
Bug 1278008 - Add all_jars to annotation processing classpath.

https://reviewboard.mozilla.org/r/57958/#review55032

¯\_(ツ)_/¯

Adding "too much" to the classpath shouldn't have a too negative effect. After all it should just make the classes available to the runtime while executing the annotation processor.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/18da1a9562090d489f8afa8b1b7ebe9a7e346b72
Bug 1278008 - Add all_jars to annotation processing classpath. r=sebastian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18da1a956209