Closed Bug 1278079 Opened 4 years ago Closed 4 years ago

Port additional changes of bug 1088763 to TB

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4549+ fixed)

RESOLVED FIXED
Thunderbird 49.0
Tracking Status
thunderbird47 --- wontfix
thunderbird48 --- fixed
thunderbird49 --- fixed
thunderbird_esr45 49+ fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

In bug 1226986 we have already ported most of bug 1088763. This bug is to port the pieces which are added after our check-in (m-c backed where patch out because of some issues and some days ago in again).
The main part of this patch is the image preloading hack. I also changed the Quick Filter Bar bottom border to the same colors as the main toolbar uses.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8760006 - Flags: review?(aleth)
Comment on attachment 8760006 [details] [diff] [review]
YosemiteTabChange.patch

Review of attachment 8760006 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. (This should probably be progressively uplifted)

Some things I noticed that look wrong in inactive windows:
- the shading on the quickfilter button in its "pressed" state (too dark)
- the Calendar and Tasks tabs quickfilter bar ("Events in the next n days contain...")
- the Calendar tab top of the calendar (with the Day/Week/... tabs), but that looks less than perfect imho when active too ;)
Attachment #8760006 - Flags: review?(aleth) → review+
(In reply to aleth [:aleth] from comment #2)
> Comment on attachment 8760006 [details] [diff] [review]
> YosemiteTabChange.patch
> 
> Review of attachment 8760006 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to me. (This should probably be progressively uplifted)

I'll do this

> Some things I noticed that look wrong in inactive windows:
> - the shading on the quickfilter button in its "pressed" state (too dark)

Good catch, I'll file a bug for this

> - the Calendar and Tasks tabs quickfilter bar ("Events in the next n days
> contain...")
> - the Calendar tab top of the calendar (with the Day/Week/... tabs), but
> that looks less than perfect imho when active too ;)

I'll file a calendar bug for this too.
https://hg.mozilla.org/comm-central/rev/309a67d48771
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
Comment on attachment 8760006 [details] [diff] [review]
YosemiteTabChange.patch

[Approval Request Comment]
Regression caused by (bug #): 1226986, not really regressed but not added all
User impact if declined: wrong colors on inactive windows
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8760006 - Flags: approval-comm-esr45?
Attachment #8760006 - Flags: approval-comm-beta?
Attachment #8760006 - Flags: approval-comm-aurora?
Comment on attachment 8760006 [details] [diff] [review]
YosemiteTabChange.patch

We missed the upload to Aurora when it was still at TB 48. Therefore I'll uplift this to TB 48 beta.

The TB 47 beta trains has already left the station.
Attachment #8760006 - Flags: approval-comm-beta?
Attachment #8760006 - Flags: approval-comm-beta+
Attachment #8760006 - Flags: approval-comm-aurora?
Comment on attachment 8760006 [details] [diff] [review]
YosemiteTabChange.patch

http://hg.mozilla.org/releases/comm-esr45/rev/8af72c49027d
Attachment #8760006 - Flags: approval-comm-esr45? → approval-comm-esr45+
You need to log in before you can comment on or make changes to this bug.