Add JS APIs for determining whether a function is bound and getting the target

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [v8api])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8760026 [details] [diff] [review]
Add JS APIs for determining whether a function is bound and getting the target
Attachment #8760026 - Flags: review?(jorendorff)
(Assignee)

Updated

2 years ago
Whiteboard: [v8api]
(Assignee)

Updated

2 years ago
Assignee: nobody → ehsan
Comment on attachment 8760026 [details] [diff] [review]
Add JS APIs for determining whether a function is bound and getting the target

Review of attachment 8760026 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.

::: js/src/jsapi-tests/testBoundFunction.cpp
@@ +26,5 @@
> +    CHECK(!!target);
> +    CHECK(JS_ObjectIsFunction(cx, target));
> +    JS::RootedValue targetVal(cx, JS::ObjectValue(*target));
> +    bool equal = false;
> +    CHECK(JS_StrictlyEqual(cx, foo, targetVal, &equal) && equal);

CHECK_SAME(foo, targetVal);
Attachment #8760026 - Flags: review?(jorendorff) → review+

Comment 3

2 years ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49b8cf82bcfc
Add JS APIs for determining whether a function is bound and getting the target; r=jorendorff

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/49b8cf82bcfc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.