Closed Bug 1278089 Opened 7 years ago Closed 7 years ago

Add JS APIs for determining whether a function is bound and getting the target

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

(Whiteboard: [v8api])

Attachments

(1 file)

Add JS APIs for determining whether a function is bound and getting the target
3.89 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review 
      No description provided.
Whiteboard: [v8api]
Assignee: nobody → ehsan
Comment on attachment 8760026 [details] [diff] [review]
Add JS APIs for determining whether a function is bound and getting the target

Review of attachment 8760026 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.

::: js/src/jsapi-tests/testBoundFunction.cpp
@@ +26,5 @@
> +    CHECK(!!target);
> +    CHECK(JS_ObjectIsFunction(cx, target));
> +    JS::RootedValue targetVal(cx, JS::ObjectValue(*target));
> +    bool equal = false;
> +    CHECK(JS_StrictlyEqual(cx, foo, targetVal, &equal) && equal);

CHECK_SAME(foo, targetVal);
Attachment #8760026 - Flags: review?(jorendorff) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49b8cf82bcfc
Add JS APIs for determining whether a function is bound and getting the target; r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/49b8cf82bcfc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.