Add a style for checked .toolbarbutton-1 on inactive windows on OSX 10.10+

RESOLVED FIXED in Thunderbird 49.0

Status

Thunderbird
Theme
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 49.0
All
Mac OS X

Thunderbird Tracking Flags

(thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4549+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
On OS X 10.10+ when the window is inactive the checked .toolbarbutton-1 (like QFB button) is too dark.
(Assignee)

Comment 1

a year ago
Created attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

Aleth, what do you think about this?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8760075 - Flags: review?(aleth)

Comment 2

a year ago
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

Review of attachment 8760075 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Shame they don't define those colors in some file one can simply import.
Attachment #8760075 - Flags: review?(aleth) → review+
(Assignee)

Comment 3

a year ago
https://hg.mozilla.org/comm-central/rev/4e2619025b77
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
(Assignee)

Comment 4

a year ago
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

[Approval Request Comment]
User impact if declined: checked toolbarbutton too prominent on inactive window with OS X 10.10+
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8760075 - Flags: approval-comm-esr45?
Attachment #8760075 - Flags: approval-comm-beta?
Attachment #8760075 - Flags: approval-comm-aurora?

Updated

a year ago
Attachment #8760075 - Flags: approval-comm-beta?
Attachment #8760075 - Flags: approval-comm-beta+
Attachment #8760075 - Flags: approval-comm-aurora?
Attachment #8760075 - Flags: approval-comm-aurora+

Updated

a year ago
status-thunderbird47: --- → wontfix
status-thunderbird48: --- → affected
status-thunderbird49: --- → fixed
status-thunderbird_esr45: --- → fixed
tracking-thunderbird_esr45: --- → ?

Updated

a year ago
status-thunderbird_esr45: fixed → affected

Comment 5

a year ago
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

This was landed on TB 49 and is therefore already on current Aurora (TB 49) after trunk moved to TB 50.
Attachment #8760075 - Flags: approval-comm-aurora+

Comment 6

a year ago
Beta (TB 48):
https://hg.mozilla.org/releases/comm-beta/rev/2093240c1abc
status-thunderbird48: affected → fixed

Comment 7

8 months ago
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

http://hg.mozilla.org/releases/comm-esr45/rev/717133ae9768
Attachment #8760075 - Flags: approval-comm-esr45? → approval-comm-esr45+

Updated

8 months ago
status-thunderbird_esr45: affected → fixed
tracking-thunderbird_esr45: ? → 49+
You need to log in before you can comment on or make changes to this bug.