1278123 - Add a style for checked .toolbarbutton-1 on inactive windows on OSX 10.10+

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

On OS X 10.10+ when the window is inactive the checked .toolbarbutton-1 (like QFB button) is too dark.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: inactiveChecked.patch

Aleth, what do you think about this?

Comment 2

[aleth [:aleth]]

Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

Review of attachment 8760075 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Shame they don't define those colors in some file one can simply import.

Comment 3

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/4e2619025b77

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

[Approval Request Comment]
User impact if declined: checked toolbarbutton too prominent on inactive window with OS X 10.10+
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

This was landed on TB 49 and is therefore already on current Aurora (TB 49) after trunk moved to TB 50.

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 48):
https://hg.mozilla.org/releases/comm-beta/rev/2093240c1abc

Comment 7

[Kent James (:rkent)]

Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

http://hg.mozilla.org/releases/comm-esr45/rev/717133ae9768