Closed Bug 1278123 Opened 3 years ago Closed 3 years ago

Add a style for checked .toolbarbutton-1 on inactive windows on OSX 10.10+

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4549+ fixed)

RESOLVED FIXED
Thunderbird 49.0
Tracking Status
thunderbird47 --- wontfix
thunderbird48 --- fixed
thunderbird49 --- fixed
thunderbird_esr45 49+ fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

On OS X 10.10+ when the window is inactive the checked .toolbarbutton-1 (like QFB button) is too dark.
Aleth, what do you think about this?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8760075 - Flags: review?(aleth)
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

Review of attachment 8760075 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Shame they don't define those colors in some file one can simply import.
Attachment #8760075 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/4e2619025b77
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

[Approval Request Comment]
User impact if declined: checked toolbarbutton too prominent on inactive window with OS X 10.10+
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8760075 - Flags: approval-comm-esr45?
Attachment #8760075 - Flags: approval-comm-beta?
Attachment #8760075 - Flags: approval-comm-aurora?
Attachment #8760075 - Flags: approval-comm-beta?
Attachment #8760075 - Flags: approval-comm-beta+
Attachment #8760075 - Flags: approval-comm-aurora?
Attachment #8760075 - Flags: approval-comm-aurora+
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

This was landed on TB 49 and is therefore already on current Aurora (TB 49) after trunk moved to TB 50.
Attachment #8760075 - Flags: approval-comm-aurora+
Comment on attachment 8760075 [details] [diff] [review]
inactiveChecked.patch

http://hg.mozilla.org/releases/comm-esr45/rev/717133ae9768
Attachment #8760075 - Flags: approval-comm-esr45? → approval-comm-esr45+
You need to log in before you can comment on or make changes to this bug.