1278138 - Enforce stricter eslint rules (arrow-spacing, comma-style) on passwordmgr

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Matthew N. [:MattN]]

Attachment: Desired .eslintrc

The shared eslintrc doesn't yet enforce the arrow-spacing and comma-style rules but we can start enforcing it for password manager sooner.

The requires creating our own .eslintrc file in toolkit/components/passwordmgr which extends the toolkit one.

I've attached the desired eslintrc file for this bug which includes some other rules that we pass but don't enforce yet. For arrow-spacing and comma-style there are some small fixes to be made.

The fixes for these two rules can be split in separate commits but ensure that each commit would pass eslint without the later ones.

Comment 1

[Saad Quadri [:saadq]]

Attachment: Bug 1278138 - Enforce stricter eslint rules (comma-style) on passwordmgr.

Review commit: https://reviewboard.mozilla.org/r/58274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58274/

Comment 2

[Saad Quadri [:saadq]]

Attachment: Bug 1278138 - Enforce stricter eslint rules (arrow-spacing) on passwordmgr

Review commit: https://reviewboard.mozilla.org/r/58276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58276/

Comment 3

[Saad Quadri [:saadq]]

Comment on attachment 8760871 [details]
Bug 1278138 - Enforce stricter eslint rules (comma-style) on passwordmgr.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58274/diff/1-2/

Comment 4

[Saad Quadri [:saadq]]

Comment on attachment 8760872 [details]
Bug 1278138 - Enforce stricter eslint rules (arrow-spacing) on passwordmgr

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58276/diff/1-2/

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8760872 [details]
Bug 1278138 - Enforce stricter eslint rules (arrow-spacing) on passwordmgr

https://reviewboard.mozilla.org/r/58276/#review55172

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8760871 [details]
Bug 1278138 - Enforce stricter eslint rules (comma-style) on passwordmgr.

https://reviewboard.mozilla.org/r/58274/#review55174

Great!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/3e5c13e91c6d
Enforce stricter eslint rules (comma-style) on passwordmgr. r=MattN
https://hg.mozilla.org/integration/fx-team/rev/1b97ee1e17b1
Enforce stricter eslint rules (arrow-spacing) on passwordmgr. r=MattN

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e5c13e91c6d
https://hg.mozilla.org/mozilla-central/rev/1b97ee1e17b1