1278157 - Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions.

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Nicholas Nethercote [inactive]]

ns{BMP,ICO}Encoder::ParseOptions() null check their pointer args and then dereference them anyway. They're never passed null in practice so let's just make them references to avoid the confusion.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8760129 [details] [diff] [review]
Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

Convert the parameters names to use the leading "a" style, or is there a different guideline for out params like this?

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be57b55e1b04c8d2508ce7686c370a8700ddd00a
Bug 1278157 - Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions. r=tnikkel.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be57b55e1b04

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8760129 [details] [diff] [review]
Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: need this to uplift bug 1348941 cleanly. I could rewrite most of the patch, but it's less error prone to just uplift this.
User impact if declined: we need bug 1348941
Fix Landed on Version: 50
Risk to taking this patch (and alternatives if risky): not risky, its been landed for almost a year, its in esr52
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8760129 [details] [diff] [review]
Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

let's get this on esr45 as prerequisite for bug 1348941

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr45/rev/a7803c36d797