Closed Bug 1278157 Opened 4 years ago Closed 4 years ago

Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions.

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- affected
firefox-esr45 --- fixed
firefox50 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 748787, CID 748788, CID 748789, CID 748790)

Attachments

(1 file)

ns{BMP,ICO}Encoder::ParseOptions() null check their pointer args and then dereference them anyway. They're never passed null in practice so let's just make them references to avoid the confusion.
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8760129 [details] [diff] [review]
Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

Convert the parameters names to use the leading "a" style, or is there a different guideline for out params like this?
Attachment #8760129 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/be57b55e1b04c8d2508ce7686c370a8700ddd00a
Bug 1278157 - Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions. r=tnikkel.
https://hg.mozilla.org/mozilla-central/rev/be57b55e1b04
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8760129 [details] [diff] [review]
Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: need this to uplift bug 1348941 cleanly. I could rewrite most of the patch, but it's less error prone to just uplift this.
User impact if declined: we need bug 1348941
Fix Landed on Version: 50
Risk to taking this patch (and alternatives if risky): not risky, its been landed for almost a year, its in esr52
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8760129 - Flags: approval-mozilla-esr45?
Comment on attachment 8760129 [details] [diff] [review]
Use references for outparams in ns{BMP,ICO}Encoder::ParseOptions

let's get this on esr45 as prerequisite for bug 1348941
Attachment #8760129 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
You need to log in before you can comment on or make changes to this bug.