|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
1.16 KB, image/png
2.30 KB, image/png
59 bytes, text/x-review-board-request
|Details | Review|
2.61 KB, image/x-icon
61.60 KB, image/png
+++ This bug was initially created as a clone of Bug #1119706 +++ By bug 1119706, Yahoo! Japan's search plugin is updated. We should update Yahoo! japan Auction icon image too.
Created attachment 8853297 [details] [diff] [review] Update Yahoo! Auction icon for Desktop Firefox (for mozilla-central repo) Patch to update Yahoo! auction icon for Desktop Firefox (mozilla-central repo)
Attachment #8853297 - Flags: review?(francesco.lodolo)
Comment on attachment 8853297 [details] [diff] [review] Update Yahoo! Auction icon for Desktop Firefox (for mozilla-central repo) Review of attachment 8853297 [details] [diff] [review]: ----------------------------------------------------------------- Images on desktop are .ico with both 16px and 32px, this is a 96px PNG (format use only on mobile).
Attachment #8853297 - Flags: review?(francesco.lodolo) → review-
Ahh, sorry I didn't noticed about it. I'll ask .ico version with 16/32px icon file and make new patch when I receive it.
If they provide 16px and 32px PNG icons, I can help creating the patch with the .ico
note: I've filed another bug to update HTTPS, domain and parameter for this plug-in: bug 1354511 I'm still waiting for the 16/32px icon files. Please wait a little more...
(In reply to Francesco Lodolo [:flod] from comment #5) > If they provide 16px and 32px PNG icons, I can help creating the patch with > the .ico I've reached the new contact person for Yahoo! Auction and get 16/32px PNG file for this now. Flod, could you please make .ico and patch (or specify the tool to create .ico) from the attachments? # I can also create the .ico file but not sure which tool (and output with meta data etc?) is best for our usage.
You can use GIMP to create the .ico (one image per layer). I'll take care of the patch.
Assignee: nobody → francesco.lodolo
Attachment #8853297 - Attachment is obsolete: true
I'm confused by this change. Yahoo auctions - http://auctions.yahoo.co.jp/ - still uses a Yahoo logo (which we are using now). I don't see this icon being used anywhere on the site. Are they planning to switch to this new icon?
Thanks creating patch, Flod. Hi Mike, they are not planning to switch favicon of the web site. They intentionally provide different one for this. I'm not sure how is the policy where they use each service specific icon for their web favicon. note: The attachment icon is also different from the icon of their iOS/Android Apps (it includes some Japanese texts and not good for small square one (like 16px/32px). I believe it's better to use different icon than their corporate icon (red Y! icon) since ja Firefox build also include Yahoo (General) search with the same icon now. Though old Firefox include search engine name in the drop-down list of the searchbox, we currently don't show search engine label in the drop-down icon list panel (except for the mouseover tips text) and we should use different icon for different search engines to make uses easily distinguish the two. Anyway, I'm now re-confirming about this and share the answer when I get the reply.
Created attachment 8857338 [details] Auction icon usage in Yahoo top page (In reply to dynamis (Tomoya ASAI) from comment #14) > Anyway, I'm now re-confirming about this and share the answer when I get the > reply. Reply from Yahoo Auction: > Yahoo Auction have two official icons: > * [ヤフオク] (Yahoo Auction in Japanese text) > used for App icon etc: https://play.google.com/store/apps/details?id=jp.co.yahoo.android.yauction > * Hammer icon > previous attachment for this bug. > Hammer icon is not used so many places but it used for the link from Yahoo > top page (https://www.yahoo.co.jp/) for example (see attachment). > > Please use the hammer icon for the search engine icon list in the dropdown > menu of the Firefox's search bar.
Background to change the icon: During the talk to switch HTTP to HTTPS (bug 1354511), I've also asked/confirmed if they need any other update about the search plug-ins. As for the icon, currently we have two same Y! icon in the search engine list panel and I confirmed if they want to use other icon for Yahoo! Auction or not. Then, they request to switch the icon to the Hammer one. # This is not drived by the plan to change their brand logo. # They use Y! icon for their favicon but logo for their auction services are the [ヤフオク] and the Hammer. Mike, is your concern clear now?
Comment on attachment 8856571 [details] Bug 1278189 - Update searchplugin icon for Yahoo! Japan Auction to match current design Sounds good to me.
Attachment #8856571 - Flags: review?(mozilla) → review+
Comment on attachment 8856571 [details] Bug 1278189 - Update searchplugin icon for Yahoo! Japan Auction to match current design https://reviewboard.mozilla.org/r/128524/#review132572
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/83253fa2791d Update searchplugin icon for Yahoo! Japan Auction to match current design r=mkaply
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.