Closed Bug 1278196 Opened 4 years ago Closed 3 years ago

Permanent message 'ImportError: No module named functools32' in logs of Windows jobs after bug 1272176 landed


(Release Engineering :: Applications: MozharnessCore, defect)

Not set


(firefox50 fixed)

Tracking Status
firefox50 --- fixed


(Reporter: aryx, Unassigned)




(1 file, 1 obsolete file)

Regression range:

After bug 1272176 landed, 'ImportError: No module named functools32' gets shown in the logs of Windows jobs including the aggregated log view.

E.g. from

17:25:25     INFO - Running post-run listener: _resource_record_post_run
17:25:25  WARNING - Exception when reporting resource usage: Traceback (most recent call last):
17:25:25  WARNING -   File "C:\slave\test\scripts\mozharness\base\", line 521, in _resource_record_post_run
17:25:25  WARNING -     self._log_resource_usage()
17:25:25  WARNING -   File "C:\slave\test\scripts\mozharness\base\", line 539, in _log_resource_usage
17:25:25  WARNING -     import jsonschema
17:25:25  WARNING -   File "C:\slave\test\build\venv\Lib\site-packages\jsonschema\", line 12, in <module>
17:25:25  WARNING -     from jsonschema.exceptions import (
17:25:25  WARNING -   File "C:\slave\test\build\venv\Lib\site-packages\jsonschema\", line 6, in <module>
17:25:25  WARNING -     from jsonschema import _utils
17:25:25  WARNING -   File "C:\slave\test\build\venv\Lib\site-packages\jsonschema\", line 6, in <module>
17:25:25  WARNING -     from jsonschema.compat import str_types, MutableMapping, urlsplit
17:25:25  WARNING -   File "C:\slave\test\build\venv\Lib\site-packages\jsonschema\", line 39, in <module>
17:25:25  WARNING -     from functools32 import lru_cache
17:25:25  WARNING - ImportError: No module named functools32 should get uploaded to our internal PyPI mirror. It is a dependency for jsonschema.

jlund: can you please upload and close this out?
Flags: needinfo?(jlund)
(In reply to Gregory Szorc [:gps] from comment #1)

> jlund: can you please upload and close this out?

seems like it is already there:

sha: f6253dfbe0538ad2e387bd8fdfd9293c925d63553f5813c4e587745416501e6d  /Users/jlund/Downloads//functools32-3.2.3-2.tar.gz
Flags: needinfo?(jlund)
Attached file Bug 1278196 - Install functools32; (obsolete) —
functools32 is a dependency of jsonschema. I guess dependencies don't get
installed automatically with whatever pip invocation we're using in mozharness.

Review commit:
See other reviews:
Attachment #8760845 - Flags: review?(jlund)
Attachment #8760845 - Flags: review?(jlund) → review-
Comment on attachment 8760845 [details]
Bug 1278196 - Install functools32;

r- on the basis I think this is a unittest (mochitest) issue not a talos one.

::: testing/mozharness/mozharness/mozilla/testing/
(Diff revision 1)
>              requirements=[os.path.join(self.talos_path,
>                                         'requirements.txt')]
>          )
> -        # install jsonschema for perfherder validation
> +        # install jsonschema for perfherder validation (functools32 is a
> +        # dependency)
> +        self.install_module(module="functools32")

is this just mochitest browser chrome?

if so, I don't think we need this installed for talos jobs.


where we can probably use line 298 mochitest condition block and install via `register_virtualenv_module` or an in-tree requirements file and append to `requirements_files`
gentle nudge, oh where are you functools32
The above push should fix the functools32 warnings we're seeing in automation (see try results: It should only be necessary until we're using a newer version of pip.
Comment on attachment 8772473 [details]
Bug 1278196 - Explicitly install functools32 w/ jsonschema
Attachment #8772473 - Flags: review?(gps) → review+
Pushed by
Explicitly install functools32 w/ jsonschema r=gps
Attachment #8760845 - Attachment is obsolete: true
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.