1278221 - Clicking "more..." In sync settings does nothing

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Go to the sync settings and click on the "More..." item just under "Disconnect...". ER: something happens. AR: nothing happens.

Fennec nightly on a nexus 4 running CM13.

Comment 1

[:Margaret Leibovic]

Grisha or Daniel, can one of you look into this?

Comment 2

[:Grisha Kruglov]

This seems like a regression from Bug 1264138. For reference, expected behaviour is that on top-right a one item menu with "Enable Debug Mode" checkbox comes up.

Comment 3

[:Grisha Kruglov]

Andrzej, does this feel like something Bug 1264138 might have caused?

Comment 4

[Andrzej Hunt :ahunt]

(In reply to :Grisha Kruglov from comment #3)
> Andrzej, does this feel like something Bug 1264138 might have caused?

Looks likely:
https://code.google.com/p/android/issues/detail?id=185217

I'm not sure whether we'll actually be able to find a way of working around that...

Comment 5

[Andrzej Hunt :ahunt]

Attachment: Bug 1278221 - Manually find the toolbar in order to show options menu

Workaround for an Android support library bug

Review commit: https://reviewboard.mozilla.org/r/58010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58010/

Comment 6

[Andrzej Hunt :ahunt]

This seems horrific, but it might be the only possible workaround. I'll add my finding to the Android bug, but that doesn't seem to be getting any traction so far so we might need to ship this (even if they fix it, we'd have to upgrade to a newer support library if/when it's fixed).

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8760445 [details]
Bug 1278221 - Manually find the toolbar in order to show options menu

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58010/diff/1-2/

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8760445 [details]
Bug 1278221 - Manually find the toolbar in order to show options menu

https://reviewboard.mozilla.org/r/58010/#review55850

Comment 10

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/ebef91ed1cf0b4d9525ea33fda5d51d96a5c6d4d
Bug 1278221 - Manually find the toolbar in order to show options menu r=sebastian

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ebef91ed1cf0

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed in build 50.0a1 (2016-06-13);
Device: LG G4 (Android 5.1).