1278245 - Searching something that starts with "/" doesn't work

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[Marco Castelluccio [:marco]]

Attachment: Screenshot_20160604-154611.png

Even if you click on the search suggestion, Firefox still thinks it is a file.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This is the same behavior as Linux desktop Firefox.

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> This is the same behavior as Linux desktop Firefox.

Not really, as I'm seeing that result when clicking on a search suggestion. On desktop if I click on the search suggestion, Firefox opens the search results.

I've also noticed that if I click on the "/mnt/etc/resolv.conf" search suggestion, Firefox opens Google. If I click on the "/mnt/etc/resolv.conf does not exist", Firefox opens the file:// page.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

I'm unable to reproduce this? If I click the search suggestion then I'm always redirected to the search page (Nightly; 50.0).

Comment 4

[Marco Castelluccio [:marco]]

Attachment: Screenshot - Suggestions

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Screenshot - Result after clicking on the suggestion

The two screenshots that I've just attached are on Nightly.

Comment 6

[Marco Castelluccio [:marco]]

Have you tried with the "/mnt/etc/resolv.conf does not exist" suggestion?

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Marco Castelluccio [:marco] from comment #6)
> Have you tried with the "/mnt/etc/resolv.conf does not exist" suggestion?

Oh, I see. Yep, this is broken. :)

Comment 8

[Tom Klein]

Can I ask what the desired behavior here is?

If we just want to do a search *every* time one of the search suggestions is clicked on, which as far as I can tell is what the search box on desktop does, then we can just remove the first leg here:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/SearchEngineRow.java#107

I would guess though that some people are used to clicking on search suggestions as a sort of url autocomplete (which I suppose is why that first leg was put there in the first place?): e.g. if I type 'www.g' then 'www.gmail.com' shows as a search suggestion and clicking on it loads gmail directly instead of searching for 'www.gmail.com' on google.  That seems useful...  We could special case search suggestions starting with '/' (or 'file:///'? or ...) to always load as searches I guess.

[Side note: it seems this hasn't been an issue with non-local-file suggestions because gecko is smarter about sorting out valid-looking non-local-file-urls from non-valid.  For example, if I type 'www.g' into fennec and click on the 'www.google search' suggestion, fennec decides it's a url and calls onUrlOpen, but when it gets to gecko, gecko figures out that's not a very good url and opens it as a search instead (at least that's what I assume is going on).]

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Tom Klein from comment #8)
> Can I ask what the desired behavior here is?

I flagged antlam to get an opinion from UX.


> If we just want to do a search *every* time one of the search suggestions is
> clicked on, which as far as I can tell is what the search box on desktop
> does, then we can just remove the first leg here:
> 
> https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/
> mozilla/gecko/home/SearchEngineRow.java#107

This is the obvious thing to do and makes sense (and is predictable!). However:


> I would guess though that some people are used to clicking on search
> suggestions as a sort of url autocomplete (which I suppose is why that first
> leg was put there in the first place?): e.g. if I type 'www.g' then
> 'www.gmail.com' shows as a search suggestion and clicking on it loads gmail
> directly instead of searching for 'www.gmail.com' on google.  That seems
> useful...  We could special case search suggestions starting with '/' (or
> 'file:///'? or ...) to always load as searches I guess.

Right. And I think we looked at telemetry in the past and saw that the first suggestion is clicked *very* often. So it /could/ be that a lot of users use this as a shortcut (instead of pressing 'enter' on the soft keyboard), but we don't really know - the first suggestion should be a good (or the best) suggestion for just a lot of searches too.

Comment 10

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

This seems a bit confusing. But from what I gather, given that "/mnt/etc/fstab is not a mountpoint" commits a search, we should commit a search with "/mnt/etc/fstab/resolv.conf does not exist" as well.

The existence of spaces in the suggestion should be a clue to Fennec that the user is looking for something with "human language" so, we should search

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

The code can be found here:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/StringUtils.java

* We should add some unit tests for that method
* Note that the same logic is used to determine if we should autocomplete a URL in the URL bar - A change shouldn't break this.

Comment 12

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1278245 - If a space is found, we assume this is a search query.

Review commit: https://reviewboard.mozilla.org/r/96172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96172/

Comment 13

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8815150 [details]
Bug 1278245 - If a space is found, we assume this is a search query.

@ahunt: Can you look at this patch? I've a bunch of things in my queue.

Comment 14

[Andrzej Hunt :ahunt]

Comment on attachment 8815150 [details]
Bug 1278245 - If a space is found, we assume this is a search query.

https://reviewboard.mozilla.org/r/96172/#review98654

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f389f44b82a
If a space is found, we assume this is a search query. r=ahunt

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6f389f44b82a

Comment 17

[Sorina Florean [:sflorean]]

Verified as fixed in build 53.0a1 (2016-12-19);
Device: Nexus 5 (Android 6.0.1).