Enforce consistent naming for Telemetry gen-* python scripts

RESOLVED FIXED in Firefox 59

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: Dexter, Assigned: leakey94, Mentored)

Tracking

(Blocks 1 bug)

Trunk
mozilla59
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment)

(In reply to Alessio Placitelli [:Dexter] from bug 1276190 comment #9)
> Given PEP0008 [1], we should probably rename the "gen-scalar*.py" to
> "generate_scalar_*.py".
> 
> > Modules should have short, all-lowercase names. Underscores can be used in the module name
> > if it improves readability. Python packages should also have short, all-lowercase names,
> > although the use of underscores is discouraged. 
> 
> [1] - https://www.python.org/dev/peps/pep-0008/#package-and-module-names
Blocks: 1201022
Points: --- → 1
Priority: -- → P3
Whiteboard: [measurement:client]
Assignee

Comment 1

2 years ago
Hi Alessio, I'd like to take this on if still required.
Flags: needinfo?(alessio.placitelli)
(In reply to Ryan Leake from comment #1)
> Hi Alessio, I'd like to take this on if still required.

Hey Ryan! Thanks for reaching out. Yes, this bug is still useful. I've assigned it to you. Please let me know if you have any question :)
Assignee: nobody → leakey94
Flags: needinfo?(alessio.placitelli)
Mentor: alessio.placitelli
Whiteboard: [measurement:client] → [measurement:client][lang=python]
Comment hidden (mozreview-request)
Reporter

Comment 4

2 years ago
mozreview-review
Comment on attachment 8930870 [details]
Bug 1278247 - Enforce consistent naming for Telemetry gen-* python scripts.

https://reviewboard.mozilla.org/r/201968/#review207408

Hey Ryan, thank you for your patch. The changes for the scalar scripts look ok, can we do the same for the other generator scripts too?

::: toolkit/components/telemetry/moz.build:153
(Diff revision 1)
>  # Generate event files.
>  event_files = [
>      'Events.yaml',
>  ]
>  
>  event_data = GENERATED_FILES['TelemetryEventData.h']

Would you mind doing the same for the histograms (e.g. `gen-histogram-*.py`) and events (`gen-event-*.py`) generator files?
Attachment #8930870 - Flags: review?(alessio.placitelli)
Assignee

Comment 5

2 years ago
(In reply to Alessio Placitelli [:Dexter] from comment #4)
> Comment on attachment 8930870 [details]
> Bug 1278247 - Enforce consistent naming for Telemetry gen-* python scripts.
> 
> https://reviewboard.mozilla.org/r/201968/#review207408
> 
> Hey Ryan, thank you for your patch. The changes for the scalar scripts look
> ok, can we do the same for the other generator scripts too?
> 
> ::: toolkit/components/telemetry/moz.build:153
> (Diff revision 1)
> >  # Generate event files.
> >  event_files = [
> >      'Events.yaml',
> >  ]
> >  
> >  event_data = GENERATED_FILES['TelemetryEventData.h']
> 
> Would you mind doing the same for the histograms (e.g. `gen-histogram-*.py`)
> and events (`gen-event-*.py`) generator files?

Sure, no problem.
Comment hidden (mozreview-request)
Reporter

Comment 7

2 years ago
mozreview-review
Comment on attachment 8930870 [details]
Bug 1278247 - Enforce consistent naming for Telemetry gen-* python scripts.

https://reviewboard.mozilla.org/r/201968/#review207758

This looks good, thanks Ryan!
Attachment #8930870 - Flags: review?(alessio.placitelli) → review+

Comment 8

2 years ago
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/85d8bab6cc6f
Enforce consistent naming for Telemetry gen-* python scripts. r=Dexter

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/85d8bab6cc6f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.