1278262 - Crash when deleting a bookmark while Firefox is syncing

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Client 06-06-16 16-52.crash

Build: 5407821
Device: IPone 6 Plus 

Steps to reproduce: 
1. Sign in to FxA on mobile device and bookmark a few pages
2. Sign in to FxA on desktop, add several bookmarks in the mobile folder and run sync
3. Go to Firfox for IOS and delete some bookmarks while sync is running

Actual results: 
- The application will crash.

Note:
- The crash will occur only when there are new bookmarks in the 'Mobile Bookmarks' folder imported from desktop to the device.

Comment 1

[Aaron Train [:aaronmt]]

reminds me of bug https://bugzilla.mozilla.org/show_bug.cgi?id=1225939

Comment 2

[Richard Newman [:rnewman]]

Yeah, this is a crash when the data changes underneath the row action.

4   UIKit                         	0x187035808 -[UITableView _endCellAnimationsWithContext:] + 12624
5   Client                        	0x10044fe80 BookmarksPanel.(tableView(UITableView, editActionsForRowAtIndexPath : NSIndexPath) -> [AnyObject]?).(closure #1) (BookmarksPanel.swift:377)

Comment 3

[Aaron Train [:aaronmt]]

Is this actionable for 5.0?

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2193

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8804387 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2193

I'm going to mark this as r- because this fix wont work.

Comment 6

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2193

Applies the revised approach :rnewman suggested where we generate a copy of the data with the removal applied to represent a transient state until the user moves away and comes back. At that point, the model is reloaded from disk to be consistent.

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8807592 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2193

Looks sane to me!

Comment 8

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/commit/f681d695d873718507f86fb5222c6d2e91c5ee8e

Comment 9

[Stephan Leroux [:sleroux]]

v6.x 9f15555