1278269 - Make a PrintTarget class and PrintTargetThebes subclass and convert all nsIDeviceContextSpec subclasses to use them

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

Attachment: patch

This patch:

 * Creates a PrintTarget base class to wrap a cairo_surface_t,
   provide a DrawTarget to draw, and provide checkpointing
   methods so consumers can ensure the cairo_surface_t's state
   is updated when they need it to be.

 * Creates a PrintTargetThebes subclass that wraps a gfxASurface
   to ease the transition away from gfxASurface. This class will
   be removed once that transition is completed.

 * Makes all of the nsIDeviceContextSpec subclasses use
   PrintTargetThebes for now.

Note that PrintTarget's API is structured a bit weirdly to allow the code in nsDeviceContext.cpp to keep doing exactly what it is doing just now. Specifically see the big comment for MakeDrawTarget. I'll change that later to get a cached DrawTarget that is created by the CreateOrNull factory method, but I need to figure out what causes the Mochitest regressions when that is done in a straightforward way.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Adds a Finish() method since we're going to need that for the patches that build on this.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8760692 [details] [diff] [review]
patch

Review of attachment 8760692 [details] [diff] [review]:
-----------------------------------------------------------------

This should probably get one or two additional reviewers for the widget code? But I think it's fine.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b70203799e11
Make a PrintTarget class and PrintTargetThebes subclass and convert all nsIDeviceContextSpec subclasses to use them. r=Bas

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b70203799e11