1278276 - Remove gfxPSSurface and move its logic to a PrintTargetPS subclass of PrintTarget

Status: RESOLVED FIXED

Description

[Jonathan Watt [:jwatt] (mostly away until Tue 10th)]

Created attachment 8760298 [details] [diff] [review]
patch

This patch:

 * Removes gfxPSSurface and moving its printing logic to a
   PrintTargetPS subclass of PrintTarget.

 * Converts the gfxPDFSurface consumers to PrintTargetPS.

 * Adds the cairo_surface_t* member to PrintTarget that all
   subclasses will set (except for PrintTargetThebes, which will
   be removed).

 * Adds the PrintTarget::MakeDrawTarget method which wraps the
   cairo_surface_t* member in a DrawTarget. Currently this is
   virtual purely so that PrintTargetThebes can override it, but
   once PrintTargetThebes goes away it should be made non-virtual.

 * Removes the SetDPI/GetDPI methods that nobody was using.

 * Removes PrintTargetThebes::RotateNeededForLandscape since no-one
   needs that any more.

Comment 1

[Jonathan Watt [:jwatt] (mostly away until Tue 10th)]

Created attachment 8760693 [details] [diff] [review]
patch

Now calls Finish() in the dtor to prevent crash.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8760693 [details] [diff] [review]
patch

Review of attachment 8760693 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/PrintTarget.cpp
@@ +18,3 @@
>    , mIsFinished(false)
>  {
> +#if 0

Why is this #if 0?

Comment 3

[Jonathan Watt [:jwatt] (mostly away until Tue 10th)]

(In reply to Bas Schouten (:bas.schouten) from comment #2)
> ::: gfx/thebes/PrintTarget.cpp
> @@ +18,3 @@
> >    , mIsFinished(false)
> >  {
> > +#if 0
> 
> Why is this #if 0?

The comment "Once PrintTargetThebes is removed, enable this assertion" should give a clue. ;) PrintTargetThebes doesn't use the mCairoSurface member since it wraps its own mThebesSurface gfxASurface member.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/136d378b0efe
Remove gfxPSSurface and move its logic to a PrintTargetPS subclass of PrintTarget. r=Bas

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/136d378b0efe