1278302 - New performance caveat branch doesn't have a failure id

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Girard (:BenWa)]

Looks like this patch was merged in and thus never got a failure id.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Bug 1278302 - Add failureid for WARP failIfMajorPerformanceCaveat.

Review commit: https://reviewboard.mozilla.org/r/57948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57948/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8760348 [details]
Bug 1278302 - Add failureid for WARP failIfMajorPerformanceCaveat.

https://reviewboard.mozilla.org/r/57948/#review54824

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7369ec85f9e5
Add failureid for WARP failIfMajorPerformanceCaveat. r=jrmuizel

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7369ec85f9e5

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8760348 [details]
Bug 1278302 - Add failureid for WARP failIfMajorPerformanceCaveat.

Approval Request Comment
[User impact if declined]: Some missing WebGL telemetry
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Very low risk simple patch

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8760348 [details]
Bug 1278302 - Add failureid for WARP failIfMajorPerformanceCaveat.

This missed the merge, adds some missing telemetry. OK to uplift to aurora 49

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/efb6717918db