Closed Bug 1278341 Opened 5 years ago Closed 3 years ago
Bootstrap's "Please choose the version of Firefox you want to build" prompt has so much text, its list of options are scrolled offscreen
Summary: Bootstrap's "Please choose the version of Firefox you want to build" prompt has too much text to show you the options → Bootstrap's "Please choose the version of Firefox you want to build" prompt has so much text, its list of options are scrolled offscreen
Here's a screenshot of approximately what this prompt looks like, for people running the bootstrap script on a Mac. (I took the screenshot on my Linux machine, but the terminal in my screenshot is the same size as the default terminal size on Mac, at least on intern Jonathan Chan's brand new Mac machine.)
Attachment #8760416 - Attachment description: screenshot → screenshot (totally unclear what the user should type after "Your choice")
Looks like this text was added in bug 1221200, mentored by nalexander. nalexander, see the attached screenshot for the problem here. (1/2/3 choice-listing is pushed offscreen by all the text.) Could you perhaps take this, or suggest an appropriate rewriting/reordering of this prompt which someone else could implement?
(In reply to Daniel Holbert [:dholbert] from comment #2) > Looks like this text was added in bug 1221200, mentored by nalexander. > > nalexander, see the attached screenshot for the problem here. (1/2/3 > choice-listing is pushed offscreen by all the text.) Could you perhaps take > this, or suggest an appropriate rewriting/reordering of this prompt which > someone else could implement? Hmm. I think we should move the note up, so that the choices and the prompt are co-located. We might also move the note into the artifacts page, or otherwise separate this. Alternately, we use $PAGER to display some of the "getting started" stuff. I'm not going to get to this; redirecting to chmanchester.
Flags: needinfo?(nalexander) → needinfo?(cmanchester)
Nick's suggestion sounds reasonable. The relevant text is in python/mozboot/mozboot/bootstrap.py
Assignee: nobody → wgianopoulos
Status: NEW → ASSIGNED
Fix typo in checkin-comment.
Attachment #8894215 - Flags: review?(nalexander)
Comment on attachment 8894215 [details] [diff] [review] bug1278341.patch Review of attachment 8894215 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, I noticed this myself on Windows.
Attachment #8894215 - Flags: review?(nalexander) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c102e5d5478 Move choices closer to prompt in mach bootstrap. r=nalexander
You need to log in before you can comment on or make changes to this bug.