Closed Bug 1278377 Opened 4 years ago Closed 4 years ago

convert script types to application/javascript in Thunderbird

Categories

(Thunderbird :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

16.57 KB, patch
mkmelin
: review+
aleth
: review+
Details | Diff | Splinter Review
There are some leftover uses of text/javascript or text/x-javascript in the 'type' attribute of some scripts in c-c.

The correct type seems to be application/javascript (per RFC 4329) and this is also what the majority of scripts in the tree use.
Attached patch patchSplinter Review
Try run: https://hg.mozilla.org/try-comm-central/rev/b9d0418d43d8bedbe589ef36750aa697c4f9feb7
Attachment #8760466 - Flags: review?(mkmelin+mozilla)
Attachment #8760466 - Flags: review?(aleth)
Comment on attachment 8760466 [details] [diff] [review]
patch

Review of attachment 8760466 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.
Attachment #8760466 - Flags: review?(aleth) → review+
I also wonder if we should drop the ';version=*' suffixes while here. Our internal code surely isn't JS 1.7 or 1.8 (from 2008). We have to update it for all the latest changes in m-c, which is now at ECMAScript 6 or so.

Unless that version specifier actually made the code to continue working without breakage (as the JS core didn't force the newer additions/rules upon it).
Comment on attachment 8760466 [details] [diff] [review]
patch

Review of attachment 8760466 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Probably shouldn't remove the version at least for (x)xhtml files. That wouldn't let you test the page directly in a browser if you used say "let" and other features not working on the web (without specifying version)
Attachment #8760466 - Flags: review?(mkmelin+mozilla) → review+
OK, then the patch does not need change.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/36d12862d0adaeb6e1c515c50ef30e7fd8548364
Bug 1278377 - convert to proper application/javascript content type. r=mkmelin,aleth
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in before you can comment on or make changes to this bug.