Closed Bug 1278381 Opened 3 years ago Closed 3 years ago

Open binary files with binary mode

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: emk, Unassigned)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This will fix some TIMEOUTs on windows:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50edfcbda382
I'm surprised nobody has ever fixed such a trivial problem.
Attachment #8760452 - Flags: review?(james)
Comment on attachment 8760452 [details] [diff] [review]
patch

Review of attachment 8760452 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

I think this gets overlooked because people tend to work on Unix-like platforms. I planned to write a lint for it, but that hasn't happened yet.
Attachment #8760452 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/fdc8e838f8fa
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.