Closed
Bug 1278381
Opened 8 years ago
Closed 8 years ago
Open binary files with binary mode
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: emk, Unassigned)
Details
Attachments
(1 file)
48.95 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
This will fix some TIMEOUTs on windows: https://treeherder.mozilla.org/#/jobs?repo=try&revision=50edfcbda382 I'm surprised nobody has ever fixed such a trivial problem.
Attachment #8760452 -
Flags: review?(james)
Comment 1•8 years ago
|
||
Comment on attachment 8760452 [details] [diff] [review] patch Review of attachment 8760452 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! I think this gets overlooked because people tend to work on Unix-like platforms. I planned to write a lint for it, but that hasn't happened yet.
Attachment #8760452 -
Flags: review?(james) → review+
Reporter | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdc8e838f8faeb2c8f487645d2e49ed51b157387 Bug 1278381 - Open binary files in binary mode. r=jgraham
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fdc8e838f8fa
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•