1278392 - use std::unique_ptr for AccIterators

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: use std::unique_ptr for AccIterators

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8760874 [details] [diff] [review]
use std::unique_ptr for AccIterators

Review of attachment 8760874 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.  r=me

::: accessible/base/Relation.h
@@ +47,5 @@
>      aRH.mLastIter = nullptr;
>      return *this;
>    }
>  
>    inline void AppendIter(AccIterable* aIter)

It would be even better if this function took unique_ptr<AccIterable> and all callsites (which currently pass in |new|'d things) were changed to use make_unique.  Then we could avoid |.reset()|.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/234044e5e804
use std::unique_ptr for AccIterators r=froydnj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/234044e5e804