1278453 - Assertion failure: mCallDataStorage.Contains(aCallData), at dom/base/Console.cpp:2316

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (manual version)

Assertion failure: mCallDataStorage.Contains(aCallData), at dom/base/Console.cpp:2316

Comment 1

[Jesse Ruderman]

1. Click button: "Start test"
2. Click button: "Finish test"

Comment 2

[Jesse Ruderman]

Attachment: stack

Comment 3

[Jesse Ruderman]

Attachment: testcase (automated version)

funfuzz/dom/automation/domInteresting.py build p.html

Comment 4

[Andrew Overholt [:overholt]]

baku, can you please take a look?

Comment 5

[Andrea Marchesini [:baku]]

Attachment: console.patch

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8761074 [details] [diff] [review]
console.patch

> Console::UnstoreCallData(ConsoleCallData* aCallData)
> {
>   AssertIsOnOwningThread();
> 
>   MOZ_ASSERT(aCallData);
>-  MOZ_ASSERT(mCallDataStorage.Contains(aCallData));
>+
>+  if (!mCallDataStorage.Contains(aCallData)) {
>+    // If we are here it's because the window has been closed while we were
>+    // doing some Console operation and Shutdown() has been called in the
>+    // meantime.
>+    return;
>+  }
>+
>   MOZ_ASSERT(!mCallDataStoragePending.Contains(aCallData));
> 
>   mCallDataStorage.RemoveElement(aCallData);
> }


I would just remove the assertion and add a comment that
mCallDataStorage.RemoveElement may not do anything if ...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f22cca9ad502
Console API should be able to deal with arguments that close the window in toString(), r=smaug

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f22cca9ad502