Closed
Bug 1278458
Opened 8 years ago
Closed 8 years ago
Include nsContentUtils.h when generating dictionaries with [ChromeOnly]
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 1277401
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | affected |
People
(Reporter: birtles, Assigned: birtles)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
|
3.13 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Generating code for a dictionary that has [ChromeOnly] member can generate compile errors because the generated code refers to nsContentUtils::ThreadsafeIsCallerChrome() without including nsIContentUtils.h
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: FRrK2j4ah4K
Attachment #8760598 -
Flags: review?(cam)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8760598 [details] [diff] [review] Include nsContentUtils.h when generating code for dictionaries with [ChromeOnly] members Review of attachment 8760598 [details] [diff] [review]: ----------------------------------------------------------------- Seems right to me, but better get someone more familiar with the codegen to review.
Attachment #8760598 -
Flags: review?(cam) → review?(bugs)
|
||
Updated•8 years ago
|
Attachment #8760598 -
Flags: review?(bugs) → review?(peterv)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8760598 [details] [diff] [review] Include nsContentUtils.h when generating code for dictionaries with [ChromeOnly] members Review of attachment 8760598 [details] [diff] [review]: ----------------------------------------------------------------- But I think bz already landed a fix for this as part of bug 1277401.
Attachment #8760598 -
Flags: review?(peterv) → review+
|
||
Updated•8 years ago
|
Whiteboard: btpp-active
|
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks. Yes, bug 1277401 appears to cover this.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•