Closed
Bug 1278468
Opened 8 years ago
Closed 8 years ago
Fix -Wshadow warnings in storage/ directory
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
8.36 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Fix and stop suppressing -Wshadow warnings in storage/ directory: storage/TelemetryVFS.cpp:81:44 [-Wshadow] declaration shadows a field of '(anonymous namespace)::IOThreadAutoTimer' storage/VacuumManager.cpp:192:25 [-Wshadow] declaration shadows a local variable storage/VacuumManager.cpp:248:13 [-Wshadow] declaration shadows a local variable storage/VacuumManager.cpp:249:14 [-Wshadow] declaration shadows a local variable storage/VacuumManager.cpp:251:19 [-Wshadow] declaration shadows a local variable storage/mozStorageConnection.cpp:971:15 [-Wshadow] declaration shadows a local variable storage/mozStorageStatement.cpp:449:19 [-Wshadow] declaration shadows a local variable storage/variantToSQLiteT_impl.h:97:16 [-Wshadow] declaration shadows a local variable
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8760606 -
Flags: review?(mak77)
Comment 2•8 years ago
|
||
Comment on attachment 8760606 [details] [diff] [review] Wshadow_storage.patch Review of attachment 8760606 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thank you!
Attachment #8760606 -
Flags: review?(mak77) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d71d5a7a70d2 Fix -Wshadow warnings in storage/ directory. r=mak
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d71d5a7a70d2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•