Fix -Wshadow warnings in storage/ directory

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

Fix and stop suppressing -Wshadow warnings in storage/ directory:

storage/TelemetryVFS.cpp:81:44 [-Wshadow] declaration shadows a field of '(anonymous namespace)::IOThreadAutoTimer'
storage/VacuumManager.cpp:192:25 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:248:13 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:249:14 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:251:19 [-Wshadow] declaration shadows a local variable
storage/mozStorageConnection.cpp:971:15 [-Wshadow] declaration shadows a local variable
storage/mozStorageStatement.cpp:449:19 [-Wshadow] declaration shadows a local variable
storage/variantToSQLiteT_impl.h:97:16 [-Wshadow] declaration shadows a local variable
Attachment #8760606 - Flags: review?(mak77)
Comment on attachment 8760606 [details] [diff] [review]
Wshadow_storage.patch

Review of attachment 8760606 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thank you!
Attachment #8760606 - Flags: review?(mak77) → review+
Whiteboard: btpp-active
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d71d5a7a70d2
Fix -Wshadow warnings in storage/ directory. r=mak
https://hg.mozilla.org/mozilla-central/rev/d71d5a7a70d2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.