1278481 - Black animation when URL bar text selection action bar is invoked/dismissed

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Tap on the URL Bar to enter edit mode
2) Tap into the URL Bar to dismiss the select
3) Long tap to select all

Expected results:
- Action bar is correctly displayed

Actual results:
- A black animation is displayed when action bar is invoked or dismissed

Note:
- please take a look at the following video:
https://www.youtube.com/watch?v=E4KESxsTwYA&feature=youtu.be

25-05 Bug 1268606 was still reproducing
26-05 the black animation is displayed

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

AppCompat adds this animation but I'm not sure if we have much control over how it does it (or even if we can disable it). We might be able to change the background color by setting a background behind the action bar, but then we face overdraw and all the fun that entails. A quick google skim doesn't turn up much.

Anthony, what would the action bar ideally look like as it enters here?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #1)
> AppCompat adds this animation but I'm not sure if we have much control over
> how it does it (or even if we can disable it). We might be able to change
> the background color by setting a background behind the action bar, but then
> we face overdraw and all the fun that entails. A quick google skim doesn't
> turn up much.
> 
> Anthony, what would the action bar ideally look like as it enters here?

Can we just restore it to the way it behaved before? that would be my best suggestion given the current circumstance.

I dont think the color is the problem here. It's more about the animation jank that happens and how it bumps things really abruptly. So, maybe a 250ms animation curve? to start, this could even be linear.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

After some investigation, I discovered an undocumented method on the support v7 ActionBar:
 `ActionBar.setShowHideAnimationEnabled(boolean)`

That sounds like what we'd want, however, `BrowserApp.getSupportActionBar` appears to always return null and I couldn't figure out why. We do intentionally disable the action bar with `android:windowActionBar` set as false and `android:windowNoTitle` as true [1] in order to display our own action bar.

So it actually makes me wonder what this action bar is that we're seeing from highlighting the text in the browser toolbar. Skimming the source [2], setShowHideAnimationEnabled is only defined in WindowDecorActionBar [3], which might explain why getSupportActionBar always returns false.

However, WindowDecorActionBar appears to be private [4] and I can't figure out how I might access it.

[1]: https://dxr.mozilla.org/mozilla-central/rev/88bebcaca249aeaca9197382e89d35b02be8292e/mobile/android/base/resources/values/themes.xml#13
[2]: http://androidxref.com/6.0.1_r10/search?q=&defs=setShowHideAnimationEnabled&refs=&path=&hist=&project=frameworks
[3]: http://androidxref.com/6.0.1_r10/xref/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/WindowDecorActionBar.java#330
[4]: https://developer.android.com/index.html#q=windowdecoractionbar

Comment 4

[Andrzej Hunt :ahunt]

I'll try to take a look at this!

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.