1278505 - Save As PDF causes: [Child 91980] ###!!! ASSERTION: Deallocator for PPrintProgressDialogChild should not be called on nsPrintingProxy.: 'Not Reached', file embedding/components/printingui/ipc/nsPrintingProxy.cpp

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Jonathan Watt [:jwatt]]

+++ This bug was initially created as a clone of Bug #1278254 +++

After getting the console output listed in bug 1278503 comment 0 on opening the Print dialog, if I then go on to select |PDF > Save as PDF...| instead of clicking Cancel the PDF does save successfully, but I get:

[Parent 91978] WARNING: NS_ENSURE_SUCCESS(*result, true) failed with result 0x80004001: file /Users/jonathan/moz/trees/i/embedding/components/printingui/ipc/PrintingParent.cpp, line 66
[Child 91980] ###!!! ASSERTION: Deallocator for PPrintProgressDialogChild should not be called on nsPrintingProxy.: 'Not Reached', file /Users/jonathan/moz/trees/i/embedding/components/printingui/ipc/nsPrintingProxy.cpp, line 232
JavaScript error: chrome://global/content/browser-content.js, line 659: TypeError: printSettings is null

while Firefox creates the PDF.

Comment 1

[Ting-Yu Chou [:ting] (away)]

:mconley, though AllocPPrintProgressDialogChild() is guaranteed won't be called, but DeallocPPrintProgressDialogChild() can be called from PPrintingChild::DeallocSubtree() or PPrintingChild::RemoveManagee(), is NS_NOTREACHED() necessary?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to Ting-Yu Chou [:ting] from comment #1)
> :mconley, though AllocPPrintProgressDialogChild() is guaranteed won't be
> called, but DeallocPPrintProgressDialogChild() can be called from
> PPrintingChild::DeallocSubtree() or PPrintingChild::RemoveManagee(), is
> NS_NOTREACHED() necessary?

I guess I hadn't considered those cases for deallocation. I think it's fine to remove that NS_NOTREACHED.

Comment 3

[Ting-Yu Chou [:ting] (away)]

Attachment: Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild().

Review commit: https://reviewboard.mozilla.org/r/66260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66260/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8773567 [details]
Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild().

https://reviewboard.mozilla.org/r/66260/#review63242

Comment 5

[Ting-Yu Chou [:ting] (away)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29a3907fc555

Comment 6

[Ting-Yu Chou [:ting] (away)]

Try looks good.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81e206ee8ba7
Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley

Comment 8

[Kan-Ru Chen [:kanru] (UTC+9)]

Can we uplift this to aurora and/or beta?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da083c636752
Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81e206ee8ba7

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da083c636752

Comment 12

[Ting-Yu Chou [:ting] (away)]

Not sure where I did wrong, but now there're two revisions with the patch...

Comment 13

[Ting-Yu Chou [:ting] (away)]

Comment on attachment 8773567 [details]
Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild().

Approval Request Comment
[Feature/regressing bug #]: 1090444
[User impact if declined]: warning or environment variable XPCOM_DEBUG_BREAK defined behavior with the debug build
[Describe test coverage new/current, TreeHerder]: existed tests
[Risks and why]: low, removed just the unneeded NS_NOTREACHED
[String/UUID change made/needed]: none

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8773567 [details]
Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild().

Fix an assert, taking it.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97ebf3a44e2b