1278540 - Increase the time window to grab an interactive loaner

Status: RESOLVED WONTFIX

(Taskcluster :: General, defect, P2)

Description

[Andrew Halberstadt [:ahal]]

Currently when you request a one-click loaner, you have 5 minutes to start an interactive session after it's ready before it will expires. This is long enough under the assumption that the loaner will be ready more or less immediately (say <1min).

But in practice, it can take even 30+ minutes to get the loaner depending on task load. This means you need to keep checking in every 5 minutes, or risk having to start the process all over again. It can be super frustrating.

Ideally we make it so interactive loaners are guaranteed to be ready quickly, but in the meantime simply bumping the 5 min window up to something like 30 min would be a huge help.

Comment 1

[Andrew Halberstadt [:ahal]]

I found this message:
https://github.com/taskcluster/taskcluster-tools/blob/master/one-click-loaner/connect/connect.jsx#L156

But can't find where that 5 minute window is defined. Jonas, any idea where it might be?

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

These are defined in docker-worker:
https://github.com/taskcluster/docker-worker/blob/523fc6c4ea02d28452fb7c84b2b5a3735742f019/config.yml#L180-L184

Maybe we should make them per-task configurable, or just set it higher there (that's an easy fix).

It can also be done in-tree by looking at the TASKCLUSTER_INTERACTIVE variable and doing "sleep 5m" if it's set... Though that's hardly ideal either.

IRC and/or web-push might help too... Or just using Web Notifications:
  https://developer.mozilla.org/en-US/docs/Web/API/notification
(not perfect, but better than nothing)

But yes, the priority of interactive loaners should probably be high, so people never have to wait.

Comment 3

[:Eli Perelman]

There is currently the ability to request notifications for interactive tasks, so the rest of this seems to be outside the realm of Tools.

Comment 4

[Brian Stack [:bstack]]

Since this bug really hasn't seen much action for a while, I'm going to close it assuming that things are nicer now. Please reopen if this should still be worked on now.