Switch Instantbird to use the Browser Console instead of the deprecated Error Console

RESOLVED FIXED in Instantbird 50

Status

Instantbird
Other
--
major
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

trunk
Instantbird 50

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1243550 +++

Intent to remove Error Console has been posted https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion

See also bug 1243550 (for Thunderbird)
(Assignee)

Comment 1

a year ago
Created attachment 8765556 [details] [diff] [review]
Patch v1

This uses the browser console instead of the (now gone) error console. It's a simple port of https://hg.mozilla.org/comm-central/rev/4da79677dea3

It *only* shows the console. We could probably show the inspector, etc. but I didn't put effort into that.
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #8765556 - Flags: review?(aleth)

Comment 2

a year ago
Comment on attachment 8765556 [details] [diff] [review]
Patch v1

Review of attachment 8765556 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

r+ as is to get rid of the build failure, feel free to replace with something better and/or followups as discussed on IRC.

Clicking on source links gives " this.gViewSourceUtils is undefined " errors.
Attachment #8765556 - Flags: review?(aleth) → review+
(Assignee)

Comment 3

a year ago
I pushed the first part of this as:
https://hg.mozilla.org/comm-central/rev/f6655db25f65
(Assignee)

Comment 4

a year ago
Created attachment 8765896 [details] [diff] [review]
Patch 2 v1

I still get a couple of warnings with this, but both viewing the source line and opening the "Learn more" links work.
Attachment #8765896 - Flags: review?(aleth)

Comment 5

a year ago
Comment on attachment 8765896 [details] [diff] [review]
Patch 2 v1

Review of attachment 8765896 [details] [diff] [review]:
-----------------------------------------------------------------

I see the warnings, but maybe they will go away when the rest of the devtools stuff is ported? (The viewsource IB uses throws a depreciation warning)
Attachment #8765896 - Flags: review?(aleth) → review+
(Assignee)

Comment 6

a year ago
https://hg.mozilla.org/comm-central/rev/4185fee13494
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 50
You need to log in before you can comment on or make changes to this bug.