Closed
Bug 1278555
Opened 9 years ago
Closed 9 years ago
Desktop bookmarks are still deletable after a failed sync call
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sleroux, Assigned: sleroux)
References
Details
Attachments
(1 file)
After experience an unrooted bookmark tree merging error, I was still able to edit/delete the bookmarks inside the desktop bookmarks folder. Since our buffer is not merged and we're in a potentially inconsistent state, we should disable editing of these bookmarks.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
status-fxios-v5.0:
--- → affected
|
|
Assignee | |
Comment 1•9 years ago
|
||
Added direction to isEditable query so we can differentiate between local/buffer bookmarks. :rnewman if you have time for feedback on this it's always most appreciated!
Attachment #8760835 -
Flags: review?(etoop)
Attachment #8760835 -
Flags: feedback?(rnewman)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8760835 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1895
Works well
Attachment #8760835 -
Flags: review?(etoop) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
master 2cfcba5d4bfa118450acbae277a1d94f6912d717
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-fxios-v6.0:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [needsuplift]
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8760835 -
Flags: feedback?(rnewman)
You need to log in
before you can comment on or make changes to this bug.
Description
•