Closed
Bug 1278568
Opened 8 years ago
Closed 8 years ago
Enable e10s with a11y in nightly and local builds
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(1 file, 1 obsolete file)
1.24 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → jmathies
Attachment #8760758 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Updated•8 years ago
|
tracking-e10s:
--- → +
Comment 2•8 years ago
|
||
Comment on attachment 8760758 [details] [diff] [review] patch I think this enables e10s + a11y for windows and OSX. OSX is probably a good thing, but I'm not sure windows is? I guess I'll leave that between you and aklotz. >+ bool isNightly = false; >+ const char* releaseChannel = NS_STRINGIFY(MOZ_UPDATE_CHANNEL); >+ isNightly = (strcmp(releaseChannel, "nightly") == 0 || >+ strcmp(releaseChannel, "default") == 0); might as well just set it once. I'd probably use NIGHTLY_BUILD or !RELEASE_BUILD (enabling on aurora seems like its probably a good idea), but whatever.
Attachment #8760758 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Fixing this so it allows nightly and aurora to run e10s with accessibility in use under linux. The old patch didn't scope this change to linux only so this fixes that as well.
Attachment #8760758 -
Attachment is obsolete: true
Attachment #8760929 -
Flags: review?(tbsaunde+mozbugs)
Updated•8 years ago
|
Attachment #8760929 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/37ba135cae82 Enable e10s with accessibility in Nightly and local builds. r=tbsaunde
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/37ba135cae82
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•