Enable e10s with a11y in nightly and local builds

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(e10s+, firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.24 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8760758 [details] [diff] [review]
patch
Assignee: nobody → jmathies
Attachment #8760758 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Updated

2 years ago
tracking-e10s: --- → +
Comment on attachment 8760758 [details] [diff] [review]
patch

I think this enables e10s + a11y for windows and OSX.  OSX is probably a good thing, but I'm not sure windows is?  I guess I'll leave that between you and aklotz.

>+  bool isNightly = false;
>+  const char* releaseChannel = NS_STRINGIFY(MOZ_UPDATE_CHANNEL);
>+  isNightly = (strcmp(releaseChannel, "nightly") == 0 ||
>+               strcmp(releaseChannel, "default") == 0);

might as well just set it once.

I'd probably use  NIGHTLY_BUILD or !RELEASE_BUILD (enabling on aurora seems like its probably a good idea), but whatever.
Attachment #8760758 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8760929 [details] [diff] [review]
patch

Fixing this so it allows nightly and aurora to run e10s with accessibility in use under linux. The old patch didn't scope this change to linux only so this fixes that as well.
Attachment #8760758 - Attachment is obsolete: true
Attachment #8760929 - Flags: review?(tbsaunde+mozbugs)
Attachment #8760929 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37ba135cae82
Enable e10s with accessibility in Nightly and local builds. r=tbsaunde
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37ba135cae82
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.