Closed Bug 1278568 Opened 8 years ago Closed 8 years ago

Enable e10s with a11y in nightly and local builds

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
e10s + ---
firefox50 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → jmathies
Attachment #8760758 - Flags: review?(tbsaunde+mozbugs)
tracking-e10s: --- → +
Comment on attachment 8760758 [details] [diff] [review]
patch

I think this enables e10s + a11y for windows and OSX.  OSX is probably a good thing, but I'm not sure windows is?  I guess I'll leave that between you and aklotz.

>+  bool isNightly = false;
>+  const char* releaseChannel = NS_STRINGIFY(MOZ_UPDATE_CHANNEL);
>+  isNightly = (strcmp(releaseChannel, "nightly") == 0 ||
>+               strcmp(releaseChannel, "default") == 0);

might as well just set it once.

I'd probably use  NIGHTLY_BUILD or !RELEASE_BUILD (enabling on aurora seems like its probably a good idea), but whatever.
Attachment #8760758 - Flags: review?(tbsaunde+mozbugs) → review+
Attached patch patchSplinter Review
Fixing this so it allows nightly and aurora to run e10s with accessibility in use under linux. The old patch didn't scope this change to linux only so this fixes that as well.
Attachment #8760758 - Attachment is obsolete: true
Attachment #8760929 - Flags: review?(tbsaunde+mozbugs)
Attachment #8760929 - Flags: review?(tbsaunde+mozbugs) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37ba135cae82
Enable e10s with accessibility in Nightly and local builds. r=tbsaunde
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/37ba135cae82
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: