1278578 - Missing space after version in About dialog

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Itiel]

Attachment: No space between the version and what's new

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

1. Install Firefox Hebrew edition (I'm almost positive it's RTL issue and not translation issue)
2. Go to Menu > About Firefox
3. Observe the version line


Actual results:

There's no space between the Firefox's version and "What's New".


Expected results:

There should be.

A screenshot is attached (from Firefox Developer Edition but the same applies to stable version as well).
I've checked the translation file and there's no space before the text in "What's New" string.
Of course I may be wrong, if that's the case tell me where a space should be added and I'll take care of it.

Comment 1

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

I have tested this issue on Windows 10 x64 with the latest Firefox release (47.0), Dev-Edition(48.0a2) and the latest Nightly (50.0a1-20160609130607) and managed to reproduce it.
After installing the Hebrew language versions of the Release and the Dev-Edition, when opening the About Firefox window, there's no space between the Firefox's version and "What's New" text.
However on the Nightly version, the issue doesn't reproduce due to the fact that there's no "What's New" text before the version number.

Comment 2

[Tomer Cohen :tomer]

* https://pontoon.mozilla.org/he/firefox-aurora/browser/chrome/browser/aboutDialog.dtd/?string=148440
* https://transvision.mozfr.org/?sourcelocale=en-US&locale=he&repo=aurora&search_type=entities&recherche=browser/chrome/browser/aboutDialog.dtd:releaseNotes.link
* https://hg.mozilla.org/releases/l10n/mozilla-aurora/he/file/tip/browser/chrome/browser/aboutDialog.dtd#l49

I guess it could be fixed with a quick workaround by adding whitespace on the string translation, but it could be better to fix it on the source. 

* chrome://browser/content/aboutDialog.xul
* chrome://browser/content/aboutDialog.css

Other RTL locales should be affected as well, as in https://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/file/tip/browser/chrome/browser/aboutDialog.dtd#l49
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/aboutDialog.dtd:releaseNotes.link&repo=aurora

Comment 3

[Itiel]

The issue seems to be fixed in 50.0a2.
You can close this bug.

Comment 4

[Itiel]

Whoops, accidently closed as INVAID. Reopening.
Someone with access please close this bug as RESOLVED FIXED.

Comment 5

[Tomer Cohen :tomer]

(In reply to ItielMaN from comment #4)
> Whoops, accidently closed as INVAID. Reopening.
> Someone with access please close this bug as RESOLVED FIXED.

Done.☺