Closed Bug 1278611 Opened 3 years ago Closed 3 years ago

move valgrind tc builds to tier1 and stop building buildbot binaries

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kmoir, Assigned: h.franciskang)

References

Details

Attachments

(3 files, 3 obsolete files)

Now that valgrind builds are running via taskcluster, we can probably move them to tier1 and stop building the buildbot binaries.
Assignee: nobody → fkang
Blocks: 1253305
Francis if you are still having problems with your buildbot patches let me know and I can run the patches against my buildbot dev masters and help you debug the errors.
Flags: needinfo?(fkang)
Flags: needinfo?(fkang)
Comment on attachment 8763613 [details] [diff] [review]
Remove valgrind script invocation from bbcustom

I think this should be sufficient to disable valgrind builds, but I'm not sure how to test it. Is there a way to get try to use my modified buildbotcustom?
Attachment #8763613 - Attachment description: I think this should be sufficient to disable valgrind builds, but I'm not sure how to test it. Is there a way to get a try run to work with my modified buildbotcustom? → Remove valgrind script invocation from bbcustom
Also, attachment 8763613 [details] [diff] [review] only prevents the valgrind bash script from being run (if it works). The script and any other remnants would have to be deleted as well.
Aren't there still references to valgrind in buildbot-configs/mozilla/config.py that need to be deleted as well?  Usually I test them on a dev-master 

https://wiki.mozilla.org/ReleaseEngineering/How_To/Setup_Personal_Development_Master

and compare the builders before and after

https://wiki.mozilla.org/ReleaseEngineering:TestingTechniques#builder_list.py_.2F_dump_master.py
Attached patch rmval.patch (obsolete) — Splinter Review
Disable the use of valgrind builders
https://travis-ci.org/hfkang/build-buildbot-configs/builds/142468014 

I've disabled valgrind builds in buildbotcustom, and removed references to it in both buildbotcustom and buildbot-configs. It is no longer installed as a mock package, nor is it enabled in try as a test option. I've tested out the two patches on my devmaster, http://dev-master2.bb.releng.use1.mozilla.com:8066/builders and all the valgrind builders have been removed. The travis run with both patches is also above. 

I also removed references to valgrind from buildbot-configs/mozilla/thunderbird_config.py as it didn't seem to be used there either. 

Remaining steps would be to delete the old valgrind directory from moz-central and the valgrind test from trychooser?
Removes valgrind builders on buildbot masters
Attachment #8763613 - Attachment is obsolete: true
Attachment #8766463 - Attachment is obsolete: true
Attachment #8767997 - Flags: review?(rail)
Remove references to valgrind from buildbot-configs
Attachment #8767998 - Flags: review?(rail)
braindump/buildbot-related/builder_list.py master/master.cfg was executed on the master before and after the patches. this diff shows the valgrind builders were removed.
Attachment #8767997 - Flags: review?(rail) → review+
Comment on attachment 8767998 [details] [diff] [review]
rm valgrind from buildbot-configs

Review of attachment 8767998 [details] [diff] [review]:
-----------------------------------------------------------------

::: tox_env.sh
@@ +20,5 @@
>  hgme braindump
>  
> +repo="buildbotcustom"
> +if [ ! -d "${TOX_WORK_DIR}/${repo}" ]; then
> +    git clone https://github.com/hfkang/build-buildbotcustom ${TOX_WORK_DIR}/buildbotcustom

I don't think you want this landed. ;)
Attachment #8767998 - Flags: review?(rail)
Attachment #8767998 - Attachment is obsolete: true
Attachment #8768036 - Flags: review?(rail)
Comment on attachment 8768036 [details] [diff] [review]
Remove valgrind from buildbot-configs

Review of attachment 8768036 [details] [diff] [review]:
-----------------------------------------------------------------

_~
    _~ )_)_~
    )_))_))_)
    _!__!__!_
    \______t/
  ~~~~~~~~~~~~~   it!
Attachment #8768036 - Flags: review?(rail) → review+
I forgot autoland wouldn't work here. What's the procedure for pushing changes to buildbot?
Flags: needinfo?(rail)
I can push them for you.
Flags: needinfo?(rail)
:fkang can this be closed?
Flags: needinfo?(fkang)
(In reply to Kim Moir [:kmoir] from comment #21)
> :fkang can this be closed?

Ah yes. I believe so. Thanks for reminding me :)
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(fkang)
Resolution: --- → FIXED
great, good work!
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.