1278611 - move valgrind tc builds to tier1 and stop building buildbot binaries

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Kim Moir [:kmoir] ET]

Now that valgrind builds are running via taskcluster, we can probably move them to tier1 and stop building the buildbot binaries.

Comment 1

[Kim Moir [:kmoir] ET]

Francis if you are still having problems with your buildbot patches let me know and I can run the patches against my buildbot dev masters and help you debug the errors.

Comment 2

[Francis Kang]

Attachment: Remove valgrind script invocation from bbcustom

Comment 3

[Francis Kang]

Comment on attachment 8763613 [details] [diff] [review]
Remove valgrind script invocation from bbcustom

I think this should be sufficient to disable valgrind builds, but I'm not sure how to test it. Is there a way to get try to use my modified buildbotcustom?

Comment 4

[Francis Kang]

Also, attachment 8763613 [details] [diff] [review] only prevents the valgrind bash script from being run (if it works). The script and any other remnants would have to be deleted as well.

Comment 5

[Kim Moir [:kmoir] ET]

Aren't there still references to valgrind in buildbot-configs/mozilla/config.py that need to be deleted as well?  Usually I test them on a dev-master 

https://wiki.mozilla.org/ReleaseEngineering/How_To/Setup_Personal_Development_Master

and compare the builders before and after

https://wiki.mozilla.org/ReleaseEngineering:TestingTechniques#builder_list.py_.2F_dump_master.py

Comment 6

[Francis Kang]

Attachment: rmval.patch

Disable the use of valgrind builders

Comment 7

[Francis Kang]

https://travis-ci.org/hfkang/build-buildbot-configs/builds/142468014 

I've disabled valgrind builds in buildbotcustom, and removed references to it in both buildbotcustom and buildbot-configs. It is no longer installed as a mock package, nor is it enabled in try as a test option. I've tested out the two patches on my devmaster, http://dev-master2.bb.releng.use1.mozilla.com:8066/builders and all the valgrind builders have been removed. The travis run with both patches is also above. 

I also removed references to valgrind from buildbot-configs/mozilla/thunderbird_config.py as it didn't seem to be used there either. 

Remaining steps would be to delete the old valgrind directory from moz-central and the valgrind test from trychooser?

Comment 8

[Francis Kang]

Attachment: rm valgrind from buildbotcustom

Removes valgrind builders on buildbot masters

Comment 9

[Francis Kang]

Attachment: rm valgrind from buildbot-configs

Remove references to valgrind from buildbot-configs

Comment 10

[Francis Kang]

Attachment: Diff of valgrind builders

braindump/buildbot-related/builder_list.py master/master.cfg was executed on the master before and after the patches. this diff shows the valgrind builders were removed.

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 8767998 [details] [diff] [review]
rm valgrind from buildbot-configs

Review of attachment 8767998 [details] [diff] [review]:
-----------------------------------------------------------------

::: tox_env.sh
@@ +20,5 @@
>  hgme braindump
>  
> +repo="buildbotcustom"
> +if [ ! -d "${TOX_WORK_DIR}/${repo}" ]; then
> +    git clone https://github.com/hfkang/build-buildbotcustom ${TOX_WORK_DIR}/buildbotcustom

I don't think you want this landed. ;)

Comment 12

[Rail Aliiev [:rail]]

BTW, feel free to kill moar stuff in https://dxr.mozilla.org/build-central/search?q=valgrind&redirect=false

Comment 13

[Francis Kang]

Attachment: Remove valgrind from buildbot-configs

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 8768036 [details] [diff] [review]
Remove valgrind from buildbot-configs

Review of attachment 8768036 [details] [diff] [review]:
-----------------------------------------------------------------

_~
    _~ )_)_~
    )_))_))_)
    _!__!__!_
    \______t/
  ~~~~~~~~~~~~~   it!

Comment 15

[Francis Kang]

I forgot autoland wouldn't work here. What's the procedure for pushing changes to buildbot?

Comment 16

[Rail Aliiev [:rail]]

I can push them for you.

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 8767997 [details] [diff] [review]
rm valgrind from buildbotcustom

https://hg.mozilla.org/build/buildbotcustom/rev/ee757cc22d46

Comment 18

[Rail Aliiev [:rail]]

Comment on attachment 8768036 [details] [diff] [review]
Remove valgrind from buildbot-configs

https://hg.mozilla.org/build/buildbot-configs/rev/e582005ba6bd

Comment 19

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/e582005ba6bd

Comment 20

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/ee757cc22d46

Comment 21

[Kim Moir [:kmoir] ET]

:fkang can this be closed?

Comment 22

[Francis Kang]

(In reply to Kim Moir [:kmoir] from comment #21)
> :fkang can this be closed?

Ah yes. I believe so. Thanks for reminding me :)

Comment 23

[Kim Moir [:kmoir] ET]

great, good work!

Comment 24

[Rail Aliiev [:rail]]

Yay!