1278619 - nav_help.xhtml: Sidebar Handle screenshot is outdated

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Isaac Schemm]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 SeaMonkey/2.42
Build ID: 20160503211837

Steps to reproduce:

Go to Browsing the Web > Navigating Web Pages > Using Sidebar or Customizing SeaMonkey > Sidebar.


Actual results:

The screenshot showing the sidebar handle also shows search results in the sidebar, a feature that no longer exists. (The screenshot is the same in both sections.)


Expected results:

The screenshot should either show the search tab without results or show another tab, such as bookmarks or history.

Comment 1

[Rainer Bielefeld]

REPRODUCIBLE with  English SeaMonkey 2.45a1  (Windows NT 6.1; WOW64; rv:48.0)  Gecko/20100101 Firefox/48.0 Build 20160308001946  (Default Classic Theme)  on German WIN7 64bit

nav_help.xhtml contains 
".../chrome/en-US/locale/en-US/communicator/help/images/sidebar.png" with search results in sidebar. This feature does not exist.

a) I wonder whether the problem is 
a1) that search results are missing in sidebar or
a2) that the help contents does not respect intended (?) new design without
    search results.
a3) I will check <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=rels1278619&sharer_id=41036>

@Isaac Schemm:
If final decision will be (a2) it would be great if you could contribute as attachment an edited screenshot "sidebar.png" with similar dimensions showing the new design.

Comment 2

[Rainer Bielefeld]

a2): "Bug 673190 - Seamonkey 2.1+ no sidebar search results, no advanced 
      multi-engine search" seems to indicate that current sidebar search panel 
      view is not intended?

Comment 3

[Isaac Schemm]

Attachment: sidebar-bookmarks.png

Here's a replacement for sidebar.png that shows the bookmarks tab instead of the search tab.
sidebar.png is only used for showing where the sidebar handle is, so using the bookmarks tab here will keep it consistent even if the search tab does eventually go back to previous behavior.

There's at least one other picture in Help showing search results in the sidebar, but that might be handled under another bug.

Comment 4

[rsx11m]

Comment on attachment 8760943 [details]
sidebar-bookmarks.png

Looks good.

(In reply to Rainer Bielefeld from comment #2)
> a2): "Bug 673190 - Seamonkey 2.1+ no sidebar search results, no advanced 
>       multi-engine search" seems to indicate that current sidebar search panel 
>       view is not intended?

I wouldn't say "intended" - it requires a reimplementation due to backend changes:

(Quoting Phoenix from bug 673190 comment #2)
> Due to migration to openSearch, this part of functionality was removed.
> Confirming as RFE, maybe someone would want to reimplement it in future...

Comment 5

[Isaac Schemm]

Attachment: sidebar-bookmarks

A patch to apply the previous attachment to the comm-central source tree

Comment 6

[Stefan [:stefanh]]

Comment on attachment 8761802 [details] [diff] [review]
sidebar-bookmarks

Looks good, thanks (stealing this from Ian).

Comment 7

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/9d75efeb816a