Closed
Bug 1278662
Opened 8 years ago
Closed 8 years ago
Remove loading-inverted.png, use loading.png instead
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Dolske, Assigned: dao)
References
Details
Attachments
(2 files)
|
254.24 KB,
image/png
|
Details | |
|
5.00 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
screenshot
Bug 750054 cleaned up the design/usage/naming of the throbber, but one it didn't touch is is chrome://global/skin/icons/loading-inverted.png (and @2x), which is used in the about dialog when an update check is in progress. The inverted flavor was added by bug 1173612, due to the other throbber not working well on the darker Nightly/DevEdition background. Right now chrome://global/skin/icons/loading.png is a spinning ring with tail/gradient, whereas loading-inverted.png a completely different indicator (like the native OS X throbber). Presumably these should be a similar design. I'm not sure if we can just drop the -inverted flavor (and simply use the normal one everywhere) or if we still need a -inverted flavor but updated to be more similar. Does loading.png work well enough on darker backgrounds?
Flags: needinfo?(shorlander)
|
Assignee | |
Comment 1•8 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #0) > Does loading.png work well enough on darker backgrounds? It does at least in this context.
Flags: needinfo?(shorlander)
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
Reporter | |
Updated•8 years ago
|
Attachment #8769985 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Updated•8 years ago
|
Summary: Unify loading.png and loading-inverted.png design → Remove loading-inverted.png, use loading.png instead
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/bbbf2ec4d6a2 Remove loading-inverted.png, use loading.png instead. r=dolske
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bbbf2ec4d6a2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•