Remove loading-inverted.png, use loading.png instead

RESOLVED FIXED in Firefox 50

Status

()

Toolkit
Themes
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Dolske, Assigned: dao)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Bug 750054 cleaned up the design/usage/naming of the throbber, but one it didn't touch is is chrome://global/skin/icons/loading-inverted.png (and @2x), which is used in the about dialog when an update check is in progress.

The inverted flavor was added by bug 1173612, due to the other throbber not working well on the darker Nightly/DevEdition background.

Right now chrome://global/skin/icons/loading.png is a spinning ring with tail/gradient, whereas loading-inverted.png a completely different indicator (like the native OS X throbber).

Presumably these should be a similar design.

I'm not sure if we can just drop the -inverted flavor (and simply use the normal one everywhere) or if we still need a -inverted flavor but updated to be more similar. Does loading.png work well enough on darker backgrounds?
Flags: needinfo?(shorlander)
(Assignee)

Comment 1

a year ago
Created attachment 8769984 [details]
screenshot

(In reply to Justin Dolske [:Dolske] from comment #0)
> Does loading.png work well enough on darker backgrounds?

It does at least in this context.
Flags: needinfo?(shorlander)
(Assignee)

Comment 2

a year ago
Created attachment 8769985 [details] [diff] [review]
patch
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8769985 - Flags: review?(dolske)
(Reporter)

Updated

a year ago
Attachment #8769985 - Flags: review?(dolske) → review+
(Assignee)

Updated

a year ago
Summary: Unify loading.png and loading-inverted.png design → Remove loading-inverted.png, use loading.png instead

Comment 3

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/bbbf2ec4d6a2
Remove loading-inverted.png, use loading.png instead. r=dolske

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bbbf2ec4d6a2
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.