1278689 - Remove push subscriptions when clearing site settings on Android

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Lina Butler [:lina]]

Following up on bug 1275436. Android has a separate module that handles this (http://searchfox.org/mozilla-central/source/mobile/android/modules/Sanitizer.jsm).

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1278689 - Remove push subscriptions when clearing site settings on Android.

Review commit: https://reviewboard.mozilla.org/r/58340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58340/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8760933 [details]
Bug 1278689 - Remove push subscriptions when clearing site settings on Android.

https://reviewboard.mozilla.org/r/58340/#review55374

Do we also support clearing push subscriptions from the site settings dialog? There is an "Edit site settings" item in the site identity popup, which appears when you tap on the security icon in the urlbar. While this UI isn't really great right now, it would be good to make sure we support revoking permissions from there as well (I assume that there's a similar UI in the "control cetner" on desktop).

Comment 3

[Lina Butler [:lina]]

(In reply to :Margaret Leibovic from comment #2)
> Do we also support clearing push subscriptions from the site settings
> dialog? There is an "Edit site settings" item in the site identity popup,
> which appears when you tap on the security icon in the urlbar.

I think we should, but I'll double-check. IIUC, this gets triggered after tapping the "Clear" button in the dialog, and nsIPermissionManager should take it from there: http://searchfox.org/mozilla-central/rev/3f096f780166bc4772199d79a79c8e3541ff99be/mobile/android/chrome/content/PermissionsHelper.js#118,175 Am I reading that right?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/5753eb3ec418
Remove push subscriptions when clearing site settings on Android. r=margaret

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5753eb3ec418

Comment 6

[:Margaret Leibovic]

(In reply to Kit Cambridge [:kitcambridge] from comment #3)
> (In reply to :Margaret Leibovic from comment #2)
> > Do we also support clearing push subscriptions from the site settings
> > dialog? There is an "Edit site settings" item in the site identity popup,
> > which appears when you tap on the security icon in the urlbar.
> 
> I think we should, but I'll double-check. IIUC, this gets triggered after
> tapping the "Clear" button in the dialog, and nsIPermissionManager should
> take it from there:
> http://searchfox.org/mozilla-central/rev/
> 3f096f780166bc4772199d79a79c8e3541ff99be/mobile/android/chrome/content/
> PermissionsHelper.js#118,175 Am I reading that right?

Assuming that push permissions are managed with the permissions manager, you're right, I think this should Just Work. Would be good to double check on a test site though.