Closed Bug 1278723 Opened 8 years ago Closed 8 years ago

Link failure with Android no-opt builds, 'ssse3_scale_data' undefined reference

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: gw280, Assigned: gw280)

Details

Attachments

(1 file, 1 obsolete file)

0001-Bug-1278723-Don-t-use-ssse3_scale_data-on-targets-th.patch
1.20 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
This is caused by bug 1266491
Assignee: nobody → gwright
Comment on attachment 8761010 [details] [diff] [review]
0001-Bug-1278723-Provide-a-stub-method-for-ssse3_scale_da.patch

Review of attachment 8761010 [details] [diff] [review]:
-----------------------------------------------------------------

msvc doesn't define __SSSE3__
Intead add the following to AttemptVideoResize
  #ifdef MOZILLA_SSE_HAVE_CPUID_DETECTION
  [current code]
  #else
  return false;
  #endif

That will make sure we still have link errors on x86 if something goes wrong.
Attachment #8761010 - Flags: review?(jmuizelaar) → review-
Attachment #8761015 - Flags: review?(jmuizelaar) → review+
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e568568aba00
Don't use ssse3_scale_data on targets that don't support SSSE3 r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/e568568aba00
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: