Link failure with Android no-opt builds, 'ssse3_scale_data' undefined reference

RESOLVED FIXED in Firefox 50

Status

()

Core
Graphics: Layers
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gw280, Assigned: gw280)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This is caused by bug 1266491
Created attachment 8761010 [details] [diff] [review]
0001-Bug-1278723-Provide-a-stub-method-for-ssse3_scale_da.patch
Attachment #8761010 - Flags: review?(jmuizelaar)
(Assignee)

Updated

2 years ago
Assignee: nobody → gwright
Comment on attachment 8761010 [details] [diff] [review]
0001-Bug-1278723-Provide-a-stub-method-for-ssse3_scale_da.patch

Review of attachment 8761010 [details] [diff] [review]:
-----------------------------------------------------------------

msvc doesn't define __SSSE3__
Intead add the following to AttemptVideoResize
  #ifdef MOZILLA_SSE_HAVE_CPUID_DETECTION
  [current code]
  #else
  return false;
  #endif

That will make sure we still have link errors on x86 if something goes wrong.
Attachment #8761010 - Flags: review?(jmuizelaar) → review-
Created attachment 8761015 [details] [diff] [review]
0001-Bug-1278723-Don-t-use-ssse3_scale_data-on-targets-th.patch
Attachment #8761010 - Attachment is obsolete: true
Attachment #8761015 - Flags: review?(jmuizelaar)
Attachment #8761015 - Flags: review?(jmuizelaar) → review+

Comment 4

2 years ago
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e568568aba00
Don't use ssse3_scale_data on targets that don't support SSSE3 r=jrmuizel

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e568568aba00
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.