1278838 - Remove separate worker binding for Performance API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - code

We want to get rid of the 'separate' binding system for workers. Here is the unification of the Performance API for main-thread and workers. The idea is that we have 1 single Performance implementation, shared for main-thread and workers.

Then, We have 2 separate implementations for the worker and main-thread methods in 2 different classes: PerformanceMainThread and PerformanceWorker.

I didn't touch any existing logic. I just moved code around, mainly.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - moving workers test in dom/performance/tests

Comment 3

[Olli Pettay [:smaug]]

uh, this is hard to review. Trying...

Comment 4

[Olli Pettay [:smaug]]

Comment on attachment 8761260 [details] [diff] [review]
part 1 - code

So here I'd really like to see some hg moves or copies.
At least for worker Performance to PerformanceWorker.
Maybe something similar could be done for the main thread case too?

Comment 5

[Olli Pettay [:smaug]]

sorry being difficult with this review, but the patch is quite large and with some hg usage, it should become easier to review and blame would look right.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 1 - code

Comment 7

[Olli Pettay [:smaug]]

The hg copy/mv usage for worker part made reviewing a lot easier. 
I guess I'll cope with the *MainThread

Comment 8

[Olli Pettay [:smaug]]

Comment on attachment 8761478 [details] [diff] [review]
part 1 - code

+
+NS_IMPL_CYCLE_COLLECTION_TRACE_BEGIN_INHERITED(PerformanceMainThread,
+                                                Performance)
extra space before Performance.


This would have been a lot faster to review if *MainThread stuff had used hg cp/mv. Now I had to compare each line manually.
Just tiny bit nagging ;)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1139b4cbf5
Remove separate worker binding for Performance API, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc09ba8c5e5f
move workers/performance tests in dom/performance/tests, r=smaug

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b1139b4cbf5
https://hg.mozilla.org/mozilla-central/rev/cc09ba8c5e5f