Closed
Bug 1278838
Opened 5 years ago
Closed 5 years ago
Remove separate worker binding for Performance API
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
(Whiteboard: btpp-active)
Attachments
(2 files, 1 obsolete file)
11.47 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
105.21 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
We want to get rid of the 'separate' binding system for workers. Here is the unification of the Performance API for main-thread and workers. The idea is that we have 1 single Performance implementation, shared for main-thread and workers. Then, We have 2 separate implementations for the worker and main-thread methods in 2 different classes: PerformanceMainThread and PerformanceWorker. I didn't touch any existing logic. I just moved code around, mainly.
Assignee: nobody → amarchesini
Attachment #8761260 -
Flags: review?(bugs)
Assignee | ||
Updated•5 years ago
|
Attachment #8761260 -
Attachment description: performance5.patch → part 1 - code
Assignee | ||
Comment 2•5 years ago
|
||
Attachment #8761273 -
Flags: review?(bugs)
Updated•5 years ago
|
Attachment #8761273 -
Flags: review?(bugs) → review+
Updated•5 years ago
|
Whiteboard: btpp-active
Comment 3•5 years ago
|
||
uh, this is hard to review. Trying...
Comment 4•5 years ago
|
||
Comment on attachment 8761260 [details] [diff] [review] part 1 - code So here I'd really like to see some hg moves or copies. At least for worker Performance to PerformanceWorker. Maybe something similar could be done for the main thread case too?
Attachment #8761260 -
Flags: review?(bugs) → review-
Comment 5•5 years ago
|
||
sorry being difficult with this review, but the patch is quite large and with some hg usage, it should become easier to review and blame would look right.
Assignee | ||
Comment 6•5 years ago
|
||
Attachment #8761260 -
Attachment is obsolete: true
Attachment #8761478 -
Flags: review?(bugs)
Comment 7•5 years ago
|
||
The hg copy/mv usage for worker part made reviewing a lot easier. I guess I'll cope with the *MainThread
Comment 8•5 years ago
|
||
Comment on attachment 8761478 [details] [diff] [review] part 1 - code + +NS_IMPL_CYCLE_COLLECTION_TRACE_BEGIN_INHERITED(PerformanceMainThread, + Performance) extra space before Performance. This would have been a lot faster to review if *MainThread stuff had used hg cp/mv. Now I had to compare each line manually. Just tiny bit nagging ;)
Attachment #8761478 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1139b4cbf5 Remove separate worker binding for Performance API, r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/cc09ba8c5e5f move workers/performance tests in dom/performance/tests, r=smaug
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b1139b4cbf5 https://hg.mozilla.org/mozilla-central/rev/cc09ba8c5e5f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•