Closed
Bug 1278843
Opened 8 years ago
Closed 8 years ago
Move PerformanceTiming code in separate files
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
46.09 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8761207 -
Flags: review?(bugs)
Comment 1•8 years ago
|
||
Comment on attachment 8761207 [details] [diff] [review] performance3.patch >+ nsDOMNavigationTiming* GetDOMTiming() const >+ { >+ return mPerformance->GetDOMTiming(); >+ } Making unrelated changes in this kind of bug greatly slows down reviewing. Here you're inlining a method which wasn't inlined. Fine this time, but please try to avoid unrelated changes in patches. and I think blame would look better if hg copy was used here. First copy and then remove the extra stuff from the new file. But ok.
Attachment #8761207 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Assignee | ||
Comment 2•8 years ago
|
||
> Making unrelated changes in this kind of bug greatly slows down reviewing.
It was already inline. Written on the bottom of nsPerformance.h. I just kept the same behavior.
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2401b6b118b3 Move PerformanceTiming code in separate files, r=smaug
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2401b6b118b3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•