Closed Bug 1278843 Opened 4 years ago Closed 4 years ago

Move PerformanceTiming code in separate files

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

No description provided.
Attachment #8761207 - Flags: review?(bugs)
Comment on attachment 8761207 [details] [diff] [review]
performance3.patch


>+  nsDOMNavigationTiming* GetDOMTiming() const
>+  {
>+    return mPerformance->GetDOMTiming();
>+  }
Making unrelated changes in this kind of bug greatly slows down reviewing.
Here you're inlining a method which wasn't inlined. Fine this time, but please try to avoid unrelated changes in patches.

and I think blame would look better if hg copy was used here. First copy and then remove the extra stuff from the new file.
But ok.
Attachment #8761207 - Flags: review?(bugs) → review+
Whiteboard: btpp-active
> Making unrelated changes in this kind of bug greatly slows down reviewing.

It was already inline. Written on the bottom of nsPerformance.h. I just kept the same behavior.
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2401b6b118b3
Move PerformanceTiming code in separate files, r=smaug
https://hg.mozilla.org/mozilla-central/rev/2401b6b118b3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.