Closed Bug 1278925 Opened 4 years ago Closed 4 years ago

micro-optimize nsCOMArray appending with already_AddRefed AppendElement

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

In all of the places touched by this patch, the smart pointer we're
appending is about to become unused, so simply .forget()'ing its
reference into the appropriate nsCOMArray works just fine.
Attachment #8761250 - Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8623823c103f
micro-optimize nsCOMArray appending with already_AddRefed AppendElement; r=erahm
https://hg.mozilla.org/mozilla-central/rev/8623823c103f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.