Closed
Bug 1278925
Opened 8 years ago
Closed 8 years ago
micro-optimize nsCOMArray appending with already_AddRefed AppendElement
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
9.38 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
In all of the places touched by this patch, the smart pointer we're appending is about to become unused, so simply .forget()'ing its reference into the appropriate nsCOMArray works just fine.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8761250 -
Flags: review?(erahm)
|
||
Updated•8 years ago
|
Attachment #8761250 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8623823c103f micro-optimize nsCOMArray appending with already_AddRefed AppendElement; r=erahm
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8623823c103f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•