Closed Bug 1278947 Opened 3 years ago Closed 3 years ago

Remove the context callback

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

XPConnect uses the context callback for the NewContext and DestroyContext 'events', but now that there's one context we can just inline the code there and remove the callback mechanism.
This only removes lines.
Attachment #8761288 - Flags: review?(luke)
bz would you be able to look at part 1? When bholley is back from PTO he can review other XPConnect patches hopefully...
Flags: needinfo?(bzbarsky)
Comment on attachment 8761286 [details] [diff] [review]
Part 1 - Remove cx callback from XPConnect

r=me.  This XPCContext stuff will all die in bug 1276310, but for the moment we're preserving behavior at least.
Flags: needinfo?(bzbarsky)
Attachment #8761286 - Flags: review+
Attachment #8761288 - Flags: review?(luke) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b974e754526b
part 1 - Stop using JSContext callback in XPConnect. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/f133ef6fc341
part 2 - Remove JSContext callback. r=luke
https://hg.mozilla.org/mozilla-central/rev/b974e754526b
https://hg.mozilla.org/mozilla-central/rev/f133ef6fc341
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.