Closed Bug 1278958 Opened 8 years ago Closed 6 years ago

Selecting review flag from a drop-down requires multiple clicks

Categories

(MozReview Graveyard :: Review Board: User Interface, defect)

Product:
MozReview Graveyard
Component:
Review Board: User Interface
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: gps, Unassigned)

References

Details

(This bug is similar to bug 1248043)

The recent changes to review flags to allow selection of {cancel, r-, r+, no change} is a welcome addition to MozReview. However, it introduced a minor UI regression: it now requires extra interaction to select the action.

Before, there was a single checkbox for "Ship It." You could simple click that. Now, there is a drop-down. You have to select the drop-down then select the item in it that you want.

I would like to see the one-click requirement of the previous "Finish Review" dialog restored. This could be achieved by using radio buttons or multiple checkboxes (as opposed to a drop-down). We could potentially also provide keyboard shortcuts for secting the desired review flag outcome.
Agreed.  I think this selection would be perfect:

https://davidwalsh.name/demo/quick-select.php

We could generate clickable/"tabable" buttons based on the options -- one less step!
Yes.  Having a default of "clear review" would be even better.
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.