Closed Bug 1278985 Opened 4 years ago Closed 4 years ago

Remove the unused URL argument from CreateChromeWindow2

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mconley, Unassigned)

References

Details

Attachments

(1 file)

nsAppStartup, which implements nsIWindowCreator2 doesn't do anything with the URL argument.

I expect this was probably used by folks who were embedding Gecko way back in the day, but for now isn't being used. I figure we can safely remove it.
This isn't used at all internally, and was probably used by people
embedding Gecko back when Gecko was more embeddable.

For now, it's just noise - I figure we can remove it.

Review commit: https://reviewboard.mozilla.org/r/58548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58548/
Attachment #8761322 - Flags: review?(mrbkap)
Blocks: 1261842
Comment on attachment 8761322 [details]
Bug 1278985 - Remove unused URL arg from CreateChromeWindow2.

https://reviewboard.mozilla.org/r/58548/#review55514

This seems reasonable.
Attachment #8761322 - Flags: review?(mrbkap) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8b366f388f6
Remove unused URL arg from CreateChromeWindow2. r=mrbkap
Gah - I forgot that this relies on some of the other stuff in bug 1261842.

I'll re-wire the relationship.
No longer blocks: 1261842
Depends on: 1261842
Flags: needinfo?(mconley)
sorry had to back this out since with this push we have perma failures like https://treeherder.mozilla.org/logviewer.html#?job_id=32055750&repo=mozilla-inbound and in tier 2 like https://treeherder.mozilla.org/logviewer.html#?job_id=32052354&repo=mozilla-inbound
Flags: needinfo?(mconley)
Yep, that's due to bug 1261842 stuff. Working on it over there, and once it's addressed, will re-land.
Flags: needinfo?(mconley)
Comment on attachment 8761322 [details]
Bug 1278985 - Remove unused URL arg from CreateChromeWindow2.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58548/diff/1-2/
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84b5a1027550
Remove unused URL arg from CreateChromeWindow2. r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/84b5a1027550
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.