1279006 - Fix another improbable race and clean up node destruction tests

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Eric Faust [:efaust]]

Attachment: Fix

After bug 1115779, I noticed that there was another GC-related race in the node destruction tests. Since then odes are created as garbage, a GC event (though very unlikely) could clean them up before we expected them to be collected, resulting in a different intermittent hang. This should clean up the issue. We can also move the rmoval listeners to a more logical place, since they are not racing singe the beginning anymore.

Comment 1

[Brian Grinstead [:bgrins]]

Comment on attachment 8761345 [details] [diff] [review]
Fix

Review of attachment 8761345 [details] [diff] [review]:
-----------------------------------------------------------------

Better in so many ways, thanks!

::: devtools/client/webaudioeditor/test/doc_destroy-nodes.html
@@ +12,5 @@
>  
>      <script type="text/javascript;version=1.8">
>        "use strict";
> +      // Keep the nodes we want to GC alive until we are ready for them to
> +      // be collected. We will zero this reference by force from the devtools

Nit: 'from the devtools side' -> 'in forceNodeCollection'

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8761345 [details] [diff] [review]
Fix

Review of attachment 8761345 [details] [diff] [review]:
-----------------------------------------------------------------

Also, please give this a sensible commit message before landing

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df61facc5659
Clean up webaudioeditor node destruction tests, and fix another race condition. (r=bgrins)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df61facc5659

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24c398084956

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/758bf5a6607b