1279014 - Remove the "Close" options from the dashboard

Status: RESOLVED FIXED

(MozReview Graveyard :: Review Board: User Interface, defect, P2)

Description

[Mark Côté [:mcote]]

We specifically disallow people from closing commit review requests by removing the "Close" button on the individual review-request views.  However, it is still possible to close any review request from the dashboard by selecting one or more checkboxes.  This is bad because it puts these review requests into a weird state, and there's no way to reopen them.  We should hide those controls on the dashboard.

Comment 1

[David Walsh :davidwalsh]

Attachment: MozReview: Hide 'Close' links in review listing sidebar (Bug 1279014).

Review commit: https://reviewboard.mozilla.org/r/58864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58864/

Comment 2

[David Walsh :davidwalsh]

https://reviewboard.mozilla.org/r/58864/#review55766

Added image of what it will look like!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8761784 [details]
MozReview: Hide 'Close' links in review listing sidebar (Bug 1279014).

https://reviewboard.mozilla.org/r/58864/#review55884

Stealing. LGTM! Thanks davidwalsh!

Comment 4

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/58864/#review55942

::: pylib/mozreview/mozreview/static/mozreview/js/default.js:9
(Diff revision 1)
> +  // Hide "Close Discarded" and "Close Submitted" in request listings
> +  $('#page_sidebar').find('a.discard, a.submit').remove();

FYI, I upstreamed some abortable signals on closing and reopening review requests that we can use to properly restrict the API calls this UI makes but I haven't gotten around to actually implementing the fix, See bug 1163095

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8761784 [details]
MozReview: Hide 'Close' links in review listing sidebar (Bug 1279014).

https://reviewboard.mozilla.org/r/58864/#review55944

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/b5ed2ccc629e
MozReview: Hide 'Close' links in review listing sidebar . r=mconley,mcote