1279016 - dont query_post_upload_cmd env var if not in buildbot infra

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Pete Moore [:pmoore][:pete]]

When taskcluster builds run in mozharness, the BuildbotMixin is inherited, even though the build is running in taskcluster. For windows try pushes, query_who gets called but cannot handle self.buildbot_config not being set.

I guess this problem must be solved for linux 64 builds, I'm not sure how though. I propose to handle with

if not self.buildbot_config:
   ....

However, maybe there is a more elegant way?

Comment 1

[Pete Moore [:pmoore][:pete]]

Looks like the linux builds use a fake buildprops.json:

https://hg.mozilla.org/mozilla-central/file/cb493102af8a/testing/docker/desktop-build/Dockerfile#l24

I don't want to do that in the windows builds, so I'll apply a fix to the code instead.

Comment 2

[Pete Moore [:pmoore][:pete]]

Attachment: bug1279016_gecko_v1.patch

That should do it.

Comment 3

[Jordan Lund (:jlund)]

Attachment: Bug 1279016 - dont query_post_upload_cmd env var if not in buildbot infra,

Review commit: https://reviewboard.mozilla.org/r/59218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59218/

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8761554 [details] [diff] [review]
bug1279016_gecko_v1.patch

pmoore and I decided to condition of the call that invokes query_who instead

Comment 5

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8762679 [details]
Bug 1279016 - dont query_post_upload_cmd env var if not in buildbot infra,

https://reviewboard.mozilla.org/r/59218/#review56252

Awesome!!!! Thanks Jordan. =)

Comment 6

[Jordan Lund (:jlund)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1e2e1c0e5912f7ad331950b63871a72ac2807a5
Bug 1279016 - dont query_post_upload_cmd env var if not in buildbot infra, r=pmoore

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1e2e1c0e591