1279034 - [Disco Pane] Expose the abilty to enable/disable an add-on from content.

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[[e-mail]]

See https://github.com/mozilla/addons-frontend/issues/547 for context.

In the new discovery pane it's possible a user can disable the add-on external to discovery pane. When that happens we have no way to enable it as installation doesn't appear to change the disabled state.

We currently only need the ability to enable a disabled add-on.

I don't know if we are ever going to need to disable an addon but it might be worth adding it at the same time in case that was needed in the future.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1279034 Add Addon.setEnabled() for a.m.o

Review commit: https://reviewboard.mozilla.org/r/60570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60570/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8765024 [details]
Bug 1279034 Add Addon.setEnabled() for a.m.o

https://reviewboard.mozilla.org/r/60570/#review57464

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8765024 [details]
Bug 1279034 Add Addon.setEnabled() for a.m.o

this is just a one-line webidl on an api that is only exposed to addons.mozilla.org but since it touches webidl it needs an r+ from a dom peer.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8765024 [details]
Bug 1279034 Add Addon.setEnabled() for a.m.o

https://reviewboard.mozilla.org/r/60570/#review57704

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb9d3d2aa71d
Add Addon.setEnabled() for a.m.o r=rhelmer,smaug

Comment 6

[Andrew Swan [:aswan]]

[Tracking Requested - why for this release]:
This is part of the add-ons manager discovery pane revamp project, which is slated to go live in 48.

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8765024 [details]
Bug 1279034 Add Addon.setEnabled() for a.m.o

Approval Request Comment
[Feature/regressing bug #]:
Add-ons Manager Discovery Pane

[User impact if declined]:
Described in complete detail at https://github.com/mozilla/addons-frontend/issues/547

[Describe test coverage new/current, TreeHerder]:
The patch adds new functionality and includes unit tests of that funcionality.

[Risks and why]: 
Risks are low, this functionality is only exposed to addons.mozilla.org.

[String/UUID change made/needed]:
none

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb9d3d2aa71d

Comment 9

[Andy McKay]

If its going to land in beta, we should land it in aurora.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8765024 [details]
Bug 1279034 Add Addon.setEnabled() for a.m.o

OK, let's take it to polish it.
Should be in 48 beta 5

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/82eb330f804c

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6f99c7b3ab4

Comment 13

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 50.0a1 (2016-06-27) under windows 10 64-bit.
 
Verified fixed on Firefox 48.0.2 (20160823121617), Firefox 49 (20160912134115), Firefox 50.0a2 (2016-09-15) and Firefox 51.0a1 (2016-09-15) under Windows 10 64-bit and Ubuntu 16.04 32-bit. The add-on is successfully enabled from Disco Pane.