1279039 - Pref off tmmbr

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Michael Froman [:mjf]]

If first TMMBR packets from Spark arrive with MaxTotalMediaBitRate > 300 we get a video freeze.  IF the initial MaxTotalMediaBitRate is less than 300 it seems to work properly.  For now, pref off.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1279039 - pref off tmmbr for now,

Review commit: https://reviewboard.mozilla.org/r/58586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58586/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8761362 [details]
Bug 1279039 - pref off tmmbr for now,

https://reviewboard.mozilla.org/r/58586/#review55564

Comment 3

[Carsten Book [:Tomcat]]

has problems to apply:
applying 78a13bba7aaf
patching file modules/libpref/init/all.js
Hunk #1 FAILED at 392
1 out of 1 hunks FAILED -- saving rejects to file modules/libpref/init/all.js.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue

can you take a look, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb7cd8510a8
pref off tmmbr for now, r=jesup

Comment 5

[Michael Froman [:mjf]]

Looks like jesup took care of it already.  Thanks!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dbb7cd8510a8

Comment 7

[Michael Froman [:mjf]]

Comment on attachment 8761362 [details]
Bug 1279039 - pref off tmmbr for now,

Approval Request Comment
[Feature/regressing bug #]: Bug 1270230 pref'd on, pref-ing off here.
[User impact if declined]: Video freezes when TMMBR packets arrive with MaxTotalMediaBitRate > 300 using Cisco Spark.
[Describe test coverage new/current, TreeHerder]: On inspection when using Spark especially over a long-distance VPN connection to provoke the issue.
[Risks and why]: Very little risk in turning this pref back off since it was off for quite some time prior to turning it on in 1270230.
[String/UUID change made/needed]: none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8761362 [details]
Bug 1279039 - pref off tmmbr for now,

Keeping this pref off in 49 as video freezes aren't fun.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6e0692bf2085