58 bytes, text/x-review-board-request
In bug 1250904 I baked the run-wizard command into the desktop-test image. Dustin points out I should have downloaded it instead rather than baking it in, oops.
The run-wizard binary (used by interactive workers) will likely need to change relatively frequently. Therefore, it should be baked directly into the docker image. This patch instead downloads it from the appropriate commit on hg.mozilla.org, only when needed. Review commit: https://reviewboard.mozilla.org/r/60834/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60834/
Attachment #8765488 - Flags: review?(dustin)
Comment on attachment 8765488 [details] Bug 1279040 - Move 'run-wizard' binary out of docker image, https://reviewboard.mozilla.org/r/60834/#review57666 I assume the download is necessary because this can work even in a case where there is no gecko checkout (e.g., test runs)?
Attachment #8765488 - Flags: review?(dustin) → review+
Yes, exactly. All this is only for things that use the desktop-test image.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/53a8197a49eb Move 'run-wizard' binary out of docker image, r=dustin
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.