Closed Bug 1279042 Opened 8 years ago Closed 8 years ago

show displayName for chat messages instead of fake generated name

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

(Whiteboard: [akita-alpha])

User Story

As a guest chatting in a Hello room, I should see the display names set by other chatters, rather than a system-generated default names. 

Tech checklist:

* use the username pref introduced in https://github.com/mozilla/loop/pull/444/files#diff-705bc24cfa6f5c1421b6e20e28b62660R1495

Note that if we implement a utils.js:getPref patterned after the getBooleanPref there, everyone can just set their name in localStorage on the guest side from devtools so that we won't need to make any UI there.

Attachments

(1 file, 1 obsolete file)

[loop] dmose:username-instead-1279042 > mozilla:akita
40 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
Assignee: nobody → dmose
Summary: get displayname from pref when available → should displayName for chat messages instead of fake generated name
Summary: should displayName for chat messages instead of fake generated name → show displayName for chat messages instead of fake generated name
Rank: 17
Rank: 17 → 20
Assignee: dmose → nobody
User Story: (updated)
Assignee: nobody → fernando.campo
Rank: 20 → 19
Blocks: 1280568
Rank: 19 → 9
Fernando, I'm hoping we can get this landed in the next few days.  Is this a possibility from your side?  If you're busy, I'm happy to pick it up (it sounded to me like there's already work-in-progress, but if not, that's fine too..
Flags: needinfo?(fernando.campo)
Yeah, I have this wip, but not completed yet. The load/save process is fine, but the username is still not updated when changed from the panel (event not properly spread out to the stores due to wrong dispatcher).

Right now I'm focusing on showing tile events on the sidebar chat. I might have time tomorrow for this, but if you want to take it over you're welcome to it. If not, any feedback on the issue is much appreciated.
Flags: needinfo?(fernando.campo)
Attachment #8765839 - Flags: feedback?(dmose)
Attachment #8765839 - Flags: feedback?(b.mcb)
There's no link between the panel and sidebar. So if you want to track changes of the name preference, you'd probably need to set up a listener via the LoopAPI for the pref.
(In reply to Mark Banner (:standard8) from comment #3)
> There's no link between the panel and sidebar. So if you want to track
> changes of the name preference, you'd probably need to set up a listener via
> the LoopAPI for the pref.

Let's spin that off to another bug.  This one is about just getting the most basic dogfoodability.  If each of us has to restart our browser once after we set the pref, that's still a big step forward.

I'll go ahead and grab this, and attach a new PR for review, as I don't have permissions to push to the existing branch in fcampo's repo.
Assignee: fernando.campo → dmose
Attachment #8765839 - Flags: feedback?(dmose)
Attachment #8765839 - Flags: feedback?(b.mcb)
Attachment #8765839 - Flags: feedback+
Attachment #8765839 - Attachment is obsolete: true
Attachment #8766178 - Flags: review?(fernando.campo)
Attachment #8766178 - Flags: review?(dcritchley)
Attachment #8766178 - Flags: review?(b.mcb)
OK, I've updated the PR by removing the unnecessary functions and adding a few tests.  Excitingly, much of the day was spent on the fact that the standalone test were running with isDesktop returning true, as well as what appears to be a bug related to some SyncThenable stubs not being called correctly (:andreio is investigating that further).

In the interest of getting dogfooding moving, I'm opting for going ahead and landing with the test skipped for now.
Attachment #8766178 - Flags: review?(dcritchley)
this has been merged already - https://github.com/mozilla/loop/commit/b26182aa56ad0f61a37a6422a98acde5481e86d0

opened bug 1283457 to deal with the Panel's change event
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #8766178 - Flags: review?(fernando.campo)
Attachment #8766178 - Flags: review?(b.mcb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: