Closed Bug 1279069 Opened 4 years ago Closed 4 years ago
When graphite is enabled nbsp are displayed as 'missing glyph'/.notdef
582 bytes, text/html
134.84 KB, application/x-font-ttf
2.58 KB, patch
|Details | Diff | Splinter Review|
When graphite is enabled nbsp are displayed as missing glyph in font. To reproduce: Set about:config gfx.font_rendering.graphite.enabled to true. Load attached test case. Make sure you have the "ShiShan LPO" font installed. (attached)
Font need for test case.
Arguably, this is a shortcoming of the font, but given that we work around such issues for OpenType fonts (via a special case in the GetNominalGlyph callback), we should probably do it for Graphite as well. In this case, we don't have a char-to-glyph callback to work with, so the obvious fix is to munge the source text prior to calling gr_make_seg.
Attachment #8761510 - Flags: review?(jmuizelaar)
Assignee: nobody → jfkthame
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(In reply to Jonathan Kew (:jfkthame) from comment #2) attachment 8761510 [details] [diff] [review] : This patch fixes things for me - Thank you.
Attachment #8761510 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c92d81f5d0fc57d6e0d49e34bc907e74ec8525a3 Bug 1279069 - Replace with <space> for Graphite shaping purposes if is not supported by the font. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.