Closed Bug 1279069 Opened 4 years ago Closed 4 years ago

When graphite is enabled nbsp are displayed as 'missing glyph'/.notdef.

Categories

(Core :: Graphics: Text, defect)

45 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: firefox, Assigned: jfkthame)

Details

Attachments

(3 files)

When graphite is enabled nbsp are displayed as missing glyph in font.

To reproduce:

Set about:config 
gfx.font_rendering.graphite.enabled to true.
Load attached test case.
Make sure you have the "ShiShan LPO" font installed. (attached)
Attached file ShiShan-LPO.ttf
Font need for test case.
Arguably, this is a shortcoming of the font, but given that we work around such issues for OpenType fonts (via a special case in the GetNominalGlyph callback), we should probably do it for Graphite as well. In this case, we don't have a char-to-glyph callback to work with, so the obvious fix is to munge the source text prior to calling gr_make_seg.
Attachment #8761510 - Flags: review?(jmuizelaar)
Assignee: nobody → jfkthame
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(In reply to Jonathan Kew (:jfkthame) from comment #2)
attachment 8761510 [details] [diff] [review] :
This patch fixes things for me - Thank you.
Attachment #8761510 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c92d81f5d0fc57d6e0d49e34bc907e74ec8525a3
Bug 1279069 - Replace &nbsp; with <space> for Graphite shaping purposes if &nbsp; is not supported by the font. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/c92d81f5d0fc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.