Closed Bug 1279087 Opened 8 years ago Closed 8 years ago

Intermittent test_bug995943.xul | Assertion count 5 is less than expected range 6-9 assertions. | Assertion count 10 is greater than expected range 6-9 assertions.

Categories

(Core :: Security: CAPS, defect, P3)

Product:
Core
Component:
Security: CAPS
Version:
49 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox49 --- wontfix
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: KWierso, Assigned: tracy)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

bug_1279087.patch
1.40 KB, patch
emk
: review+
Details | Diff | Splinter Review 
https://treeherder.mozilla.org/logviewer.html#?job_id=9833595&repo=fx-team
Summary: Intermittent test_bug995943.xul | Assertion count 5 is less than expected range 6-9 assertions. → Intermittent test_bug995943.xul | Assertion count 5 is less than expected range 6-9 assertions. | Assertion count 10 is greater than expected range 6-9 assertions.
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
See bug 1067022. It looks like the Mac OS X 10.10 assertion should be 5.  It appears to have been changed in https://hg.mozilla.org/mozilla-central/rev/435366291502.  

   if (navigator.userAgent.indexOf("Mac OS X 10.10") != -1)
-    SimpleTest.expectAssertions(5); // See bug 1067022
+    SimpleTest.expectAssertions(6, 9); // See bug 1067022

Masatoshi Kimura, was the above change intentional?
Flags: needinfo?(VYV03354)
I bumped the assertion count because the fix for bug 1205027 increased the assertion count and bug 1067022 didn't explain why the value was 5.
Flags: needinfo?(VYV03354)
Masatoshi, :jimm and I discussed this; he believes we should expand the range to 5-9. 

Basic patch attached for your review.
Assignee: nobody → twalker
Status: NEW → ASSIGNED
Attachment #8794802 - Flags: review?(VYV03354)
Attachment #8794802 - Flags: review?(VYV03354) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fa571b68dce
In caps/tests/mochitests/bug995943.xul, widen range of assertion check for OSX 10.10 to 5-9 to reduce intermittent test timeouts. r=emk
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7fa571b68dce
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
FWIW, there's a 10 assertion version of this failure as well.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: