127910 - Mozilla crashes on certain messages received from pop3 server

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect, P1)

Description

[Roscoe Primrose]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.8+)
Gecko/20020226
BuildID:    2002022603

Mozilla will periodically crash when receiving mail from my pop3 server.  The
crashes are related to specific e-mails.  Removing the offending e-mail from the
spool file will allow normal operation of mozilla.  I've currently got a spool
file with a single message that will crash mozilla every time.  This message was
received normally, not specially generated to crate the crash condition.  This
has been going on for several months, (I update builds 2-3 times a week) and
appears to affect at least win98se as well.  These messages seem to d/l just
fine w/outlook and pegasus mail.

Reproducible: Always
Steps to Reproduce:
1.Have an offending message in your mail spool
2.try to download via pop3
3.mozilla crashes

Actual Results:  mozilla crashes trying to d/l the offending messages

Expected Results:  mozilla should d/l the messages

TB3395333H
TB3394417M
TB3154286K
TB3102946Q
TB3102944E

Comment 1

[Navin Gupta]

Can you send the message to [e-mail], thanks

Comment 2

[Navin Gupta]

confirming based on talkback reports. 

Comment 3

[scottputterman]

Navin, were you able to reproduce this?

Comment 4

[Navin Gupta]

I just tried reproducing it with the message roscoe sent to [e-mail]
and couldn't. 

Comment 5

[Navin Gupta]

that was with the latest build 20020226

Comment 6

[Roscoe Primrose]

I could, very easily, setup a temporary mail account on my server and setup the
mail file in your spool...

Comment 7

[esther]

Roscoe, per you offer "I could, very easily, setup a temporary mail account on
my server and setup the mail file in your spool..."  could you do this for me. 
I would like to reproduce this bug.  Thanks, Esther 

Comment 8

[esther]

Rosco gave me a temp mail account.  I added this account to 4.7 first to see if
it would work there.  It works, sends and gets messages.  I then migrated it to
a trunk build 3-22 on winxp.  the profile migrated OK, messages came over but
when I gave password to login in I crash.  I tried this again this time creating
a new profile then adding the account, again I crash after giving password.  I
have not checked leave messages on server and there were no messages on server
because when I did a Get Msg from 4.7 no messages were found so I don't think my
crash is caused by a message like reported in original scenario.  Here is my
crash stack:
PL_HashString [../../../lib/ds/plhash.c, line 524]
nsPop3Protocol::GetFakeUidlTop
[d:\builds\seamonkey\mozilla\mailnews\local\src\nsPop3Protocol.cpp, line 1454]
nsPop3Protocol::ProcessProtocolState
[d:\builds\seamonkey\mozilla\mailnews\local\src\nsPop3Protocol.cpp, line 2845]
nsMsgProtocol::OnDataAvailable
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgProtocol.cpp, line 246]
nsOnDataAvailableEvent::HandleEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerProxy.cpp, line 188]
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591]
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c,
line 524]
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line
1072]
USER32.dll + 0x3c076 (0x77d7c076)
USER32.dll + 0x3c076 (0x77d7c076)
netscp6.exe + 0x6770 (0x00406770)
kernel32.dll + 0x3bb86 (0x77e9bb86) 

Comment 9

[esther]

Ijust looked at Roscoe's talkback on 2-26, it's the same as mine, but his report
says it happens when he's receiving certain mail messages.  Again, when I did a
Get Msg there were no messages on the server because Get Msg on 4.7 right before
and right after told me there were no messages.  Still investigating, navin do
you want the test accont to try it out.

Comment 10

[Roscoe Primrose]

I just looked at the server, and the message that I'd isolated as causing the
crash is still in the spool file for the test account.

Comment 11

[Navin Gupta]

Attachment: proposed fix

The fix is to check for message-id-token to be non null. if it is null we 
will not get any match in the lookup table.

Comment 12

[Navin Gupta]

david, can you review, I will also get scott to sr. 

Comment 13

[David :Bienvenu]

Comment on attachment 76314 [details] [diff] [review]
proposed fix

r=bienvenu

Comment 14

[Scott MacGregor]

Comment on attachment 76314 [details] [diff] [review]
proposed fix

sr=mscott

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 76314 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 16

[Navin Gupta]

fixed

Comment 17

[Navin Gupta]

*** Bug 127984 has been marked as a duplicate of this bug. ***

Comment 18

[Sheela Ravindran]

Reporter,
Do you still have that message or the temp account you set up? If you do can you
send it to me so that I can verify this bug.  Thanks.

Comment 19

[Sheela Ravindran]

I created the test account with the info I received from the reporter via email 
with 05-20-08 branch build. I created this account in an existing profile and 
was able to retrieve message without any crashes.  I want to make sure if that 
message that was causing this problem is still in the spool for this account. 
Reporter, can you please confirm that for me.  Thanks. 

Comment 20

[Sheela Ravindran]

Reporter's comment via email: 

I re-copied the offending message to the test account spool.

Based on the above response I got from the reporter. I created this test account 
as a second account in one of the existing profiles. Using branch build from 
2002-05-21-08 on win98 I am not able retrieve any messages from this account. I 
two of my test messages in this account and they are gone.  Also when I telnet I 
see one message on the server which I am not able to retrieve.

Reporter,
Can you just check to make sure you are able to retrieve this message on a 
recent branch build?  Thanks. 

Comment 21

[Sheela Ravindran]

After consulting with Bienvenu via email, I am marking this bug as verified 
since I don't crash anymore.  I have logged a separate bug for not being able to 
retrieve this message. Bug # 147727